Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image-Copy Extension - Argument of type 'NoneType' error #193

Closed
rohrerb opened this issue May 29, 2018 · 6 comments
Closed

Image-Copy Extension - Argument of type 'NoneType' error #193

rohrerb opened this issue May 29, 2018 · 6 comments

Comments

@rohrerb
Copy link

rohrerb commented May 29, 2018

Receiving this error when using the extension.

Getting os disk id of the source vm/image
argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 332, in execute
six.reraise(*sys.exc_info())
File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 306, in execute
result = cmd(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 167, in call
return super(AzCliCommand, self).call(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/knack/commands.py", line 109, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 420, in default_command_handler
result = op(**command_args)
File "/home/saadmin/.azure/cliextensions/image-copy-extension/azext_imagecopy/custom.py", line 29, in imagecopy
if 'id' not in json_cmd_output['storageProfile']['osDisk']['managedDisk']:
TypeError: argument of type 'NoneType' is not iterable

If i invoke this code manually i am able to view the json of the image.

az --version

azure-cli (2.0.32)

acr (2.0.24)
acs (2.0.32)
advisor (0.5.1)
ams (0.1.0)
appservice (0.1.32)
backup (1.1.1)
batch (3.2.2)
batchai (0.2.2)
billing (0.1.8)
cdn (0.0.14)
cloud (2.0.13)
cognitiveservices (0.1.13)
command-modules-nspkg (2.0.1)
configure (2.0.15)
consumption (0.3.1)
container (0.1.23)
core (2.0.32)
cosmosdb (0.1.21)
dla (0.0.19)
dls (0.0.21)
dms (0.0.1)
eventgrid (0.1.12)
eventhubs (0.1.3)
extension (0.0.13)
feedback (2.1.1)
find (0.2.9)
interactive (0.3.20)
iot (0.1.20)
keyvault (2.0.21)
lab (0.0.22)
monitor (0.1.6)
network (2.1.0)
nspkg (3.0.2)
profile (2.0.24)
rdbms (0.2.2)
redis (0.2.13)
reservations (0.1.2)
resource (2.0.28)
role (2.0.23)
servicebus (0.1.2)
servicefabric (0.0.12)
sql (2.0.25)
storage (2.0.32)
vm (2.0.31)

Extensions:
image-copy-extension (0.0.6)

Python location '/opt/az/bin/python3'
Extensions directory '/home/saadmin/.azure/cliextensions'

Python (Linux) 3.6.1 (default, Apr 30 2018, 23:14:03)
[GCC 5.4.0 20160609]

Legal docs and information: aka.ms/AzureCliLegal

@tamirkamara
Copy link
Contributor

@rohrerb can you rerun the command with the --debug flag and post the full output (it will include all sub commands and their output)?

@rohrerb
Copy link
Author

rohrerb commented May 30, 2018

Getting os disk id of the source vm/image
command: ['/opt/az/bin/python3', '-m', 'azure.cli', 'image', 'show', '--name', 'baseCentos_7.5', '--resource-group', 'CustomImage', '--output', 'json'] ended with output: {
"additionalProperties": {},
"id": "/subscriptions//resourceGroups/CustomImage/providers/Microsoft.Compute/images/baseCentos_7.5",
"location": "westus",
"name": "baseCentos_7.5",
"provisioningState": "Succeeded",
"resourceGroup": "CustomImage",
"sourceVirtualMachine": null,
"storageProfile": {
"additionalProperties": {},
"dataDisks": [],
"osDisk": {
"additionalProperties": {},
"blobUri": "https://.blob.core.windows.net/disks/baseCentos_7.5.vhd",
"caching": "None",
"diskSizeGb": 32,
"managedDisk": null,
"osState": "Generalized",
"osType": "Linux",
"snapshot": null,
"storageAccountType": "Standard_LRS"
},
"zoneResilient": null
},
"tags": {},
"type": "Microsoft.Compute/images"
}

argument of type 'NoneType' is not iterable
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 197, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 332, in execute
six.reraise(*sys.exc_info())
File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 306, in execute
result = cmd(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 167, in call
return super(AzCliCommand, self).call(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/knack/commands.py", line 109, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 420, in default_command_handler
result = op(**command_args)
File "/home/saadmin/.azure/cliextensions/image-copy-extension/azext_imagecopy/custom.py", line 29, in imagecopy
if 'id' not in json_cmd_output['storageProfile']['osDisk']['managedDisk']:
TypeError: argument of type 'NoneType' is not iterable

@tamirkamara
Copy link
Contributor

tamirkamara commented May 30, 2018

@rohrerb It looks like the image you're trying to copy isn't a managed one since it's based on a vhd. right?
The extension is able to work with managed images only, and the error is a result of checking that which I'll fix.

@rohrerb
Copy link
Author

rohrerb commented May 30, 2018

@tamirkamara

Pretty sure its a managed image. The image was generated using this command.

az image create -g $rg -n $imageName --os-type Linux --source https://$storname.blob.core.$vhdblobendpointname.net/disks/$vhdblobname

@rohrerb
Copy link
Author

rohrerb commented Jun 1, 2018

Thoughts @tamirkamara?

@tamirkamara
Copy link
Contributor

Updated issue: the extension doesn't support copying images backed by a vhd disk stored as blob.
It will be added soon.

evelyn-ys pushed a commit that referenced this issue Jan 28, 2023
* Kubernetes Data Protection Extension CLI (#173)

* First draft for Data Protection K8s backup extension (Pending internal review)

* Removing tracing

* Minor changes to improve azdev style

* Internal PR review feedback

Co-authored-by: Rishabh Raj <rishraj@microsoft.com>

* {AKS - ARC} fix: Update DCR creation to Clusters resource group instead of workspace (#175)

* fix: Update DCR creation to Clusters resource group instead of workspace

* .

* .

* casing check

* Add self-signed cert to fix PR gate for azureml extension

* adding the api version to the operation definition in the client factory

* bump k8s-extension version to 1.3.6

* adding tests for all 4 extension types calls

* adding to test config file

* updating the api version for extension types to be the correct version expected by the service

* add test case for flux extension (#184)

* bump k8s-extension version to 1.3.6

* bump k8s-extension version to 1.3.6

* adding upstream test for extension types

* updating history.rst

* [Dapr] Prompt user for existing Dapr installation during extension create (#188)

* Add more validations and user prompt for existing installation scenario

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add Dapr test'

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle stateful set

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update default handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix HA handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add placement service todo

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add non-interactive mode

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Reset configuration for StatefulSet during k8s upgrade

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Retrigger tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add changes to manage ha and placement params

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update message

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* nits

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* bump k8s-extension version to 1.3.7

* [Dapr] Disable applying CRDs during a downgrade (#193)

* Add logging

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update log

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert applyCrds when not downgrading

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update logic for removing hooks.applyCrds

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle explicit hooks configuration

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update comment

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* ContainerInsights extension -  Add dataCollectionSettings configuration settings (#200)

* data collection settings

* add support for dataCollectionSettings

* fix indention

* avoid duplicate use of json loads

* remove whitespaces

* fix pr feedback

* Upgrade Python version from 3.6 to 3.7 (#203)

* Upgrade Python version from 3.6 to 3.10

Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software.

* Upgrade to Python 3.10 from 3.6

Upgrade to 3.10 as 3.6 is not supported

* Switch PyLink to 1.9.4

Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10

* Use Python 3.7 for Static Analysis

Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools

* Try unpinned version of PyLint

PyLint 1.9.5 doesn't work with Python 3.7.  So, trying to see if it automatically pulls the latest compatible version.

* Run pylint as a separate command

* Update pylintrc (#204)

* Update pylintrc

* Update k8s-custom-pipelines.yml

* Disable PyLint (#205)

Disable PyLint for now, as the new version has breaking changes and requires lot more fixes

* Disable PyLint on CI scripts

* Fixes for script errors

* Upgrade Static Analysis Python version

Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled

* Try 3.9, as 3.10 has breaking changes for Flake8

* Remove version pinning for flake8

Try Python 3.10, without pinning flake8 to a version

* Update k8s-custom-pipelines.yml

* Use Python 3.8.1 & flake8 6.0.0

* Use Python 3.8 instead of 3.8.1

* Update k8s-custom-pipelines.yml

* Update .flake8

Update to reflect breaking change in flake8 6.0

* Update source_code_static_analysis.py

Scope static analysis tools to only k8s-extension module's source in our branch.

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update pool name in StaticAnalysis

To mirror what is in main of azure-cli-extensions

* Update k8s-custom-pipelines.yml

* Fix indentation

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Revert changes

* Revert changes

* Revert changes to source_code_static_analysis.py

* Update source_code_static_analysis.py

* Revert changes

* Use Ubuntu 20.4 for BuiltTestPublish stage

* Switch to ubuntu-20.04 from latest

Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>

* [Dapr] Do not apply CRD hook when version is unchanged or auto-upgrade is being disabled (#201)

* Update logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>

* add dummy key for amalogs as well

* bump k8s-extension version to 1.3.8

* Adding GA api version 2022-11-01 exposing isSystemExtension and support for plan info

* Seperate args for plan name, product and publisher

* updating cassete file

* updating HISTORY.rst

* k8s-extension release 1.3.8

---------

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Rishabh Raj <rishabhstpaul@gmail.com>
Co-authored-by: Rishabh Raj <rishraj@microsoft.com>
Co-authored-by: bragi92 <kadubey@microsoft.com>
Co-authored-by: Yue Yu <yuyu3@microsoft.com>
Co-authored-by: Deeksha Sharma <deesharma@microsoft.com>
Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Co-authored-by: Ganga Mahesh Siddem <gangams@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>
Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>
Co-authored-by: Amol Agrawal <amagraw@microsoft.com>
Co-authored-by: Amol Agrawal <pfrcks@gmail.com>
Co-authored-by: Arif Lakhani <ariflakhani@microsoft.com>
Co-authored-by: Arif-lakhani <ariflakhani7786@gmail.com>
evelyn-ys pushed a commit that referenced this issue Jan 31, 2023
* Kubernetes Data Protection Extension CLI (#173)

* First draft for Data Protection K8s backup extension (Pending internal review)

* Removing tracing

* Minor changes to improve azdev style

* Internal PR review feedback

Co-authored-by: Rishabh Raj <rishraj@microsoft.com>

* {AKS - ARC} fix: Update DCR creation to Clusters resource group instead of workspace (#175)

* fix: Update DCR creation to Clusters resource group instead of workspace

* .

* .

* casing check

* Add self-signed cert to fix PR gate for azureml extension

* adding the api version to the operation definition in the client factory

* bump k8s-extension version to 1.3.6

* adding tests for all 4 extension types calls

* adding to test config file

* updating the api version for extension types to be the correct version expected by the service

* add test case for flux extension (#184)

* bump k8s-extension version to 1.3.6

* bump k8s-extension version to 1.3.6

* adding upstream test for extension types

* updating history.rst

* [Dapr] Prompt user for existing Dapr installation during extension create (#188)

* Add more validations and user prompt for existing installation scenario

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add Dapr test'

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle stateful set

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update default handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix HA handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add placement service todo

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add non-interactive mode

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Reset configuration for StatefulSet during k8s upgrade

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Retrigger tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add changes to manage ha and placement params

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update message

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* nits

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* bump k8s-extension version to 1.3.7

* [Dapr] Disable applying CRDs during a downgrade (#193)

* Add logging

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update log

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert applyCrds when not downgrading

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update logic for removing hooks.applyCrds

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle explicit hooks configuration

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update comment

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* ContainerInsights extension -  Add dataCollectionSettings configuration settings (#200)

* data collection settings

* add support for dataCollectionSettings

* fix indention

* avoid duplicate use of json loads

* remove whitespaces

* fix pr feedback

* Upgrade Python version from 3.6 to 3.7 (#203)

* Upgrade Python version from 3.6 to 3.10

Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software.

* Upgrade to Python 3.10 from 3.6

Upgrade to 3.10 as 3.6 is not supported

* Switch PyLink to 1.9.4

Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10

* Use Python 3.7 for Static Analysis

Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools

* Try unpinned version of PyLint

PyLint 1.9.5 doesn't work with Python 3.7.  So, trying to see if it automatically pulls the latest compatible version.

* Run pylint as a separate command

* Update pylintrc (#204)

* Update pylintrc

* Update k8s-custom-pipelines.yml

* Disable PyLint (#205)

Disable PyLint for now, as the new version has breaking changes and requires lot more fixes

* Disable PyLint on CI scripts

* Fixes for script errors

* Upgrade Static Analysis Python version

Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled

* Try 3.9, as 3.10 has breaking changes for Flake8

* Remove version pinning for flake8

Try Python 3.10, without pinning flake8 to a version

* Update k8s-custom-pipelines.yml

* Use Python 3.8.1 & flake8 6.0.0

* Use Python 3.8 instead of 3.8.1

* Update k8s-custom-pipelines.yml

* Update .flake8

Update to reflect breaking change in flake8 6.0

* Update source_code_static_analysis.py

Scope static analysis tools to only k8s-extension module's source in our branch.

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update pool name in StaticAnalysis

To mirror what is in main of azure-cli-extensions

* Update k8s-custom-pipelines.yml

* Fix indentation

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Revert changes

* Revert changes

* Revert changes to source_code_static_analysis.py

* Update source_code_static_analysis.py

* Revert changes

* Use Ubuntu 20.4 for BuiltTestPublish stage

* Switch to ubuntu-20.04 from latest

Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>

* [Dapr] Do not apply CRD hook when version is unchanged or auto-upgrade is being disabled (#201)

* Update logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>

* add dummy key for amalogs as well

* bump k8s-extension version to 1.3.8

* Adding GA api version 2022-11-01 exposing isSystemExtension and support for plan info

* Seperate args for plan name, product and publisher

* updating cassete file

* updating HISTORY.rst

* Deprecate longer parameter names when accepting config settings (#213)

Co-authored-by: deeksha345 <34255011+deeksha345@users.noreply.github.com>

* Release 1.3.9

* [k8s-extension] Update extension CLI to v1.3.9

---------

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Rishabh Raj <rishabhstpaul@gmail.com>
Co-authored-by: Rishabh Raj <rishraj@microsoft.com>
Co-authored-by: bragi92 <kadubey@microsoft.com>
Co-authored-by: Yue Yu <yuyu3@microsoft.com>
Co-authored-by: Deeksha Sharma <deesharma@microsoft.com>
Co-authored-by: deeksha345 <34255011+deeksha345@users.noreply.github.com>
Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Co-authored-by: Ganga Mahesh Siddem <gangams@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>
Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>
Co-authored-by: Amol Agrawal <amagraw@microsoft.com>
Co-authored-by: Amol Agrawal <pfrcks@gmail.com>
Co-authored-by: Arif Lakhani <ariflakhani@microsoft.com>
ms-hujia pushed a commit to ms-hujia/azure-cli-extensions that referenced this issue Jun 21, 2023
* Add logging

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update log

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert applyCrds when not downgrading

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update logic for removing hooks.applyCrds

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle explicit hooks configuration

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update comment

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
wangzelin007 pushed a commit that referenced this issue Sep 4, 2023
* Kubernetes Data Protection Extension CLI (#173)

* First draft for Data Protection K8s backup extension (Pending internal review)

* Removing tracing

* Minor changes to improve azdev style

* Internal PR review feedback

Co-authored-by: Rishabh Raj <rishraj@microsoft.com>

* {AKS - ARC} fix: Update DCR creation to Clusters resource group instead of workspace (#175)

* fix: Update DCR creation to Clusters resource group instead of workspace

* .

* .

* casing check

* Add self-signed cert to fix PR gate for azureml extension

* adding the api version to the operation definition in the client factory

* bump k8s-extension version to 1.3.6

* adding tests for all 4 extension types calls

* adding to test config file

* updating the api version for extension types to be the correct version expected by the service

* add test case for flux extension (#184)

* bump k8s-extension version to 1.3.6

* bump k8s-extension version to 1.3.6

* adding upstream test for extension types

* updating history.rst

* [Dapr] Prompt user for existing Dapr installation during extension create (#188)

* Add more validations and user prompt for existing installation scenario

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add Dapr test'

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle stateful set

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update default handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix HA handling

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add placement service todo

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add non-interactive mode

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Reset configuration for StatefulSet during k8s upgrade

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Fix lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Retrigger tests

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add changes to manage ha and placement params

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update message

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* nits

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* bump k8s-extension version to 1.3.7

* [Dapr] Disable applying CRDs during a downgrade (#193)

* Add logging

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Lint

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update log

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert applyCrds when not downgrading

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update logic for removing hooks.applyCrds

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Revert logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Handle explicit hooks configuration

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Update comment

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* ContainerInsights extension -  Add dataCollectionSettings configuration settings (#200)

* data collection settings

* add support for dataCollectionSettings

* fix indention

* avoid duplicate use of json loads

* remove whitespaces

* fix pr feedback

* Upgrade Python version from 3.6 to 3.7 (#203)

* Upgrade Python version from 3.6 to 3.10

Upgrade to 3.10 for the job that runs Wheel, PyLint, Flake, etc., since 3.6 is not supported anymore by hosted-agent-software.

* Upgrade to Python 3.10 from 3.6

Upgrade to 3.10 as 3.6 is not supported

* Switch PyLink to 1.9.4

Switch PyLink to 1.9.4 from 1.9.5, as 1.9.5 is not supported with Python 3.10

* Use Python 3.7 for Static Analysis

Use 3.7, as 3.10 does not support certain properties used by astpeephole.py that is used by Static Analysis tools

* Try unpinned version of PyLint

PyLint 1.9.5 doesn't work with Python 3.7.  So, trying to see if it automatically pulls the latest compatible version.

* Run pylint as a separate command

* Update pylintrc (#204)

* Update pylintrc

* Update k8s-custom-pipelines.yml

* Disable PyLint (#205)

Disable PyLint for now, as the new version has breaking changes and requires lot more fixes

* Disable PyLint on CI scripts

* Fixes for script errors

* Upgrade Static Analysis Python version

Upgrade the Python version for Static Analysis to 3.10, from 3.7, now that PyLint is disabled

* Try 3.9, as 3.10 has breaking changes for Flake8

* Remove version pinning for flake8

Try Python 3.10, without pinning flake8 to a version

* Update k8s-custom-pipelines.yml

* Use Python 3.8.1 & flake8 6.0.0

* Use Python 3.8 instead of 3.8.1

* Update k8s-custom-pipelines.yml

* Update .flake8

Update to reflect breaking change in flake8 6.0

* Update source_code_static_analysis.py

Scope static analysis tools to only k8s-extension module's source in our branch.

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Update pool name in StaticAnalysis

To mirror what is in main of azure-cli-extensions

* Update k8s-custom-pipelines.yml

* Fix indentation

* Update k8s-custom-pipelines.yml

* Update k8s-custom-pipelines.yml

* Revert changes

* Revert changes

* Revert changes to source_code_static_analysis.py

* Update source_code_static_analysis.py

* Revert changes

* Use Ubuntu 20.4 for BuiltTestPublish stage

* Switch to ubuntu-20.04 from latest

Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>

* [Dapr] Do not apply CRD hook when version is unchanged or auto-upgrade is being disabled (#201)

* Update logic

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* re-trigger pipeline

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>

* add dummy key for amalogs as well

* bump k8s-extension version to 1.3.8

* Adding GA api version 2022-11-01 exposing isSystemExtension and support for plan info

* Seperate args for plan name, product and publisher

* updating cassete file

* updating HISTORY.rst

* Deprecate longer parameter names when accepting config settings (#213)

Co-authored-by: deeksha345 <34255011+deeksha345@users.noreply.github.com>

* Release 1.3.9

* make containerinsights dcr name consistent (#211)

Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com>

* [Dapr] Update version comparison logic to use semver based comparison (#219)

* Update semver comparison

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Add log

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

---------

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* bump k8s-extension version to 1.4.0 (#220)

* Revert "bump k8s-extension version to 1.4.0 (#220)" (#222)

This reverts commit ffb8a95.

* [k8s-extension] Update extension CLI to v1.4.0

* update release history

* fix openservice mesh cli testcase issue

* Zetia/fix ssl secret flag (#224)

* fix bug: update operation doesn't respect sslSecret parameter

* fix bug: update operation doesn't respect sslSecret parameter

* fix typo

* feat: public preview support for microsoft.azuremonitor.containers.metrics in ARC clusters (managed prometheus) (#227)

* remove redundant extension test (#230)

* ci MSI default for arc cluster (#231)

* bump k8s-extension version to 1.4.2

* ContainerInsights extension - Extend dataCollectionSettings config settings with streams field (#232)

* extend containerinsights datacollection settings with streams field

* bug fix

* fix lint issues

* fix pr feedback

* fix pr feedback

* fix lint error

* Generated files for 2023-05-01-preview

* Support for 2023-05-01-preview

* Rename get to show

* Added ExtensionType api test cases

* ContainerInsights extension - Extend dataCollectionSettings with containerlogv2 (#237)

* Fix for Liniting issues

* Fixing test cases

* comment failing test cases

* [k8s-extension] add kind tag in DCR creation (#240)

* Use semver package (#241)

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>

* Reverting commented test cases

* Add support to skip provisioning of prerequisites for Azure Monitor K8s extensions (#234)

* {ARC} fix: update logic to sanitize cluster name for dc* objects (#242)

* Fix osm-arc version check for CI tags (#244)

Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Co-authored-by: nshankar <nshankar@microsoft.ghe.com>

* New cassette file

* Remove unused propeties from table format

* bump k8s-extension version 1.4.3

* Add old commands back with deprecated status

* Fix linting issues

* Reverting changes for extensions type api

* change the location for test runs and arc clusters

* [k8s-extension] create new cli release - v1.4.3 (#250)

* Revert "[k8s-extension] create new cli release - v1.4.3 (#250)" (#251)

This reverts commit 584815d.

* [k8s-extension] Update extension CLI to v1.4.3

* Drop relay sdk (#254)

* update readme

* remove useless snippets (#256)

* [k8s-extension] Update extension CLI to v1.4.4

---------

Signed-off-by: Shubham Sharma <shubhash@microsoft.com>
Signed-off-by: nshankar <nshankar@microsoft.ghe.com>
Co-authored-by: Rishabh Raj <rishabhstpaul@gmail.com>
Co-authored-by: Rishabh Raj <rishraj@microsoft.com>
Co-authored-by: bragi92 <kadubey@microsoft.com>
Co-authored-by: Yue Yu <yuyu3@microsoft.com>
Co-authored-by: Deeksha Sharma <deesharma@microsoft.com>
Co-authored-by: deeksha345 <34255011+deeksha345@users.noreply.github.com>
Co-authored-by: Shubham Sharma <shubhash@microsoft.com>
Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com>
Co-authored-by: Ganga Mahesh Siddem <gangams@microsoft.com>
Co-authored-by: NarayanThiru <nanthi@microsoft.com>
Co-authored-by: Rishik Hombal <hombalrishik@gmail.com>
Co-authored-by: Amol Agrawal <amagraw@microsoft.com>
Co-authored-by: Amol Agrawal <pfrcks@gmail.com>
Co-authored-by: Arif Lakhani <ariflakhani@microsoft.com>
Co-authored-by: Arif-lakhani <ariflakhani7786@gmail.com>
Co-authored-by: Zeliang Tian <83852443+zetiaatgithub@users.noreply.github.com>
Co-authored-by: Long Wan <wanlonghenry@gmail.com>
Co-authored-by: ms-hujia <48512395+ms-hujia@users.noreply.github.com>
Co-authored-by: Niranjan Shankar <nshankar@microsoft.com>
Co-authored-by: nshankar <nshankar@microsoft.ghe.com>
Co-authored-by: necusjz <necusjz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants