Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with publishing to bot #202

Merged
merged 4 commits into from
Jun 14, 2018
Merged

fix issue with publishing to bot #202

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e23eda
fix missing client error during publish
Jun 13, 2018
8fea9a8
update index.json
Jun 13, 2018
4aac3ca
Merge branch 'master' into master
swagatmishra2007 Jun 14, 2018
40c8a77
remove unused client variable
Jun 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/botservice/azext_bot/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def create_app(cmd, client, resource_group_name, resource_name, description, kin
return create_bot_json(cmd, client, resource_group_name, resource_name, app_password=password)


def publish_app(cmd, _, resource_group_name, resource_name, git_url=None, git_token=None, git_branch='master', # pylint: disable=inconsistent-return-statements
def publish_app(cmd, client, resource_group_name, resource_name, git_url=None, git_token=None, git_branch='master', # pylint: disable=inconsistent-return-statements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parameter is not being used in the function. You may want to remove it entirely.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@williexu i am going to be making change to this code path in my next iteration shortly when i will need the client. So instead of removing this now and readding (and changing the extension package at the source blob again), can we get this in for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i see why you suggest this..the build is detecting hte unused parameter and failing...i will remove it

code_dir=None):
# if given msbot json, use that to update environment settings like luis settings
if git_url:
Expand Down
2 changes: 1 addition & 1 deletion src/botservice/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
logger.warn("Wheel is not available, disabling bdist_wheel hook")
cmdclass = {}

VERSION = "0.0.2"
VERSION = "0.0.3"
# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
CLASSIFIERS = [
Expand Down
8 changes: 4 additions & 4 deletions src/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -840,9 +840,9 @@
],
"botservice": [
{
"filename": "botservice-0.0.2-py2.py3-none-any.whl",
"sha256Digest": "bfacf788883301a7711243287cdd3e38feea50d750bbe8e6b6284a29dfef78f0",
"downloadUrl": "https://icscratch.blob.core.windows.net/bot-packages/botservice-0.0.2-py2.py3-none-any.whl",
"filename": "botservice-0.0.3-py2.py3-none-any.whl",
"sha256Digest": "2bab390922c1ad9b6fa645b651540e7c8de14f20213fd6848a6fa67f0636f699",
"downloadUrl": "https://icscratch.blob.core.windows.net/bot-packages/botservice-0.0.3-py2.py3-none-any.whl",
"metadata": {
"azext.minCliCoreVersion": "2.0.30",
"azext.isPreview": true,
Expand All @@ -868,7 +868,7 @@
"metadata_version": "2.0",
"name": "botservice",
"summary": "Support for Azure Bot Service 2017-12-01 preview features",
"version": "0.0.2"
"version": "0.0.3"
}
}
],
Expand Down