Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aks: add --enable-pod-identity-with-kubenet flag #3062

Merged
merged 9 commits into from
Mar 2, 2021

Conversation

bcho
Copy link
Member

@bcho bcho commented Feb 26, 2021

This pull request implemented support for enabling AAD Pod Identity addon in AKS cluster using Kubnet network plugin. With the 2021-02-01 API version, we can:

  • create cluster, with Kubnet network plugin + enable AAD Pod Identity addon:
$ az aks create -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --enable-pod-identity --enable-pod-identity-with-kubenet

If we don't set this flag, we will raise following error:

$ az aks create -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --enable-pod-identity 
The behavior of this command has been altered by the following extension: aks-preview
--enable-pod-identity-with-kubenet is required for enabling pod identity addon when using Kubenet network plugin
  • update cluster that using Kubnet network plugin to enable AAD Pod Identity addon:
$ az aks update -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --enable-pod-identity --enable-pod-identity-with-kubenet
# no change for disabling addon
$ az aks update -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --disable-pod-identity

For cluster using Azure CNI network plugin, this flag is no-op. User can still toggle this addon with following commands:

$ az aks create -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --enable-pod-identity --network-plugin azure
$ az aks create -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --disable-pod-identity
$ az aks create -g $MY_RESOURCE_GROUP -n $MY_CLUSTER --enable-pod-identity

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@bcho
Copy link
Member Author

bcho commented Mar 2, 2021

@fengzhou-msft could you help review this PR? Thanks!

@fengzhou-msft fengzhou-msft merged commit 32ccfec into Azure:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants