[k8s-extension] Patch Bug in OpenServiceMesh with dependency on pyhelm
#3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] release from Azure:master
…into k8s-extension/public-preview
* Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import
…into k8s-extension/public
…es/azure-cli-extensions into k8s-extension/public
Co-authored-by: Yue Yu <yuyu3@microsoft.com>
…into k8s-extension/public
* Servicebus client model changes * Fix testing script * Update history file and pipeline * Update min cli core version for track 2 updates
* first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
…into k8s-extension/public
* first sketch of the change fixes removed extra blank lines changes regarding param renaming added ssl tests added more detail to the unit test additional import moved pem files out of public folder fixed import chenged import changed import unit tests fix unit test fix fixed unit tests fixed unit test unit test fix changes int test cert and key * test protected config * fix test typo * temporary changes reverted * fixing tests * fixed file paths * removed accidentally added file * changes according to review comments * more changes according to review comments * changes according to review comments * fixed decode error * renamed the experimental param Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
* fixed scoring fe related extension params * bug fix and style fixes * variable rename * fixed the error type * set cluster to prod by default
* Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
* Add distro validation for osm-arc * fixed indentation * Fix linting * Resolve comments * Add unit test * fix lint Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
…es/azure-cli-extensions into k8s-extension/public
removed release-train logic
* Add custom delete logic * Fix failing unit tests
* add warning message * fix indentation
…into k8s-extension/public
* Fix OSM pyhelm bug * Debug bootstrap error
…into k8s-extension/public
jonathan-innis
force-pushed
the
k8s-extension/release-0.5.1
branch
from
723eecb
to
4fa6ab8
Compare
|
k8s-extension |
zhoxing-ms
reviewed
Jul 9, 2021
Comment on lines
+142
to
+154
| # try: | ||
| # chart_arc = ChartBuilder({ | ||
| # "name": OpenServiceMesh.CHART_NAME, | ||
| # "version": str(chart_version), | ||
| # "source": { | ||
| # "type": "repo", | ||
| # "location": OpenServiceMesh.CHART_LOCATION | ||
| # } | ||
| # }) | ||
| # except VersionError: | ||
| # raise InvalidArgumentValueError( | ||
| # "Invalid version '{}' for microsoft.openservicemesh".format(chart_version) | ||
| # ) |
There was a problem hiding this comment.
I'd like to ask why we need to block those code?
There was a problem hiding this comment.
We are trying to change this eventually; however, for now since this is partner code, I didn't want to completely remove it but instead mark it as unused
zhoxing-ms
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.