[k8s-configuration] Release v1.2.0 with Flux v2 Support #4100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[pull] release from Azure:master
…into k8s-configuration
…into k8s-extension/public-preview
* Update models to track2 * Increase k8s-configuration version number * Update kind version * Change error to warning because of DSA failure
…into k8s-configuration
…into k8s-configuration
…into k8s-configuration
* Scaffold out the k8s-config package * Base implementation of CLI commands * Add create scenario and cleanup in consts * Add help text to commands, params * Add other clients to client factory * Automatically installing the flux extension * Move flux and extension into modules * Updated the versioned sdks * Push working command for testing * Update to multi api versioned sdk * Support other extension methods * Fix nullity check * Add source control provider * Add scc commands * Add defer logic for create with cache * Use default extension with identity * Fix identity creation * Add kustomization caching * Add formatters * Add scc provider * Add help text for k8s-config fluxv1 * Add help text for extension * Allow force delete of extension and fluxconfiguration * Add location to the extension model * Update with latest from k8s-extension * Add k8s-config testing * Add license header * Fix all style issues * Update codeowners file * Validate data before checking cluster compliance * No kustomizations warning * Fix identity issue in 2020-07-01 * Fix k8s regex * Fix configuration name regex validation * Fix name length validation * Adding some validation warnings * Add protected settings to request * Exclude private test path * Add suspend functionality * Add correct values to build Kustomization * Add no_wait * Fix style issues * Use base64 encoded httpsUser * Fix formatting error and base64 encoding error * Fix style issues * Fix force * Updated help text * Style fixes * Increase namespace maximum len * Add managed cluster support to k8s-config * Custom confirmation when prune is enabled * Add flux commands to existing k8s-configuration * Remove extension provider from CLI * Fix style issues * Override extension variables * Strip newlines from known_hosts file * Update help text and validators * Strip newlines from known hosts * Add provisioning state check for flux extension * Pin helm version * Remove validation from create command * Add patch support with new SDK * Add implementation for CRUD of source and kustomization * Fix errors on patch * Fix some bugs in patching properties * Add fixes for patch in k8s-configuraiton * Change duration formatting in table output * Add validation and conversion for durations * Bump verison and fix typo * Fix bug with dependencies * Fix linter and style issues * Fix delete prune check * Add flux testing * Create separate jobs for scenarios * Update error text
…into k8s-configuration
|
k8s-configuration |
zhoxing-ms
reviewed
Nov 15, 2021
Comment on lines
1
to
11
| # -------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for | ||
| # license information. | ||
| # | ||
| # Code generated by Microsoft (R) AutoRest Code Generator. | ||
| # Changes may cause incorrect behavior and will be lost if the code is | ||
| # regenerated. | ||
| # -------------------------------------------------------------------------- | ||
| VERSION = "0.2.0" | ||
| # -------------------------------------------------------------------------- | ||
| # Copyright (c) Microsoft Corporation. All rights reserved. | ||
| # Licensed under the MIT License. See License.txt in the project root for | ||
| # license information. | ||
| # | ||
| # Code generated by Microsoft (R) AutoRest Code Generator. | ||
| # Changes may cause incorrect behavior and will be lost if the code is | ||
| # regenerated. | ||
| # -------------------------------------------------------------------------- | ||
|
|
||
| VERSION = "0.2.0" |
There was a problem hiding this comment.
Why do we need to modify this file?
zhoxing-ms
reviewed
Nov 15, 2021
zhoxing-ms
reviewed
Nov 15, 2021
| help='Base64-encoded HTTPS CA certificate for TLS communication with private repository sync') | ||
| c.argument('https_ca_cert_file', | ||
| arg_group="Auth", | ||
| help='Filepath to HTTPS CA certificate file for TLS communication with private repository sync') |
There was a problem hiding this comment.
Suggested change
| help='Filepath to HTTPS CA certificate file for TLS communication with private repository sync') | |
| help='File path to HTTPS CA certificate file for TLS communication with private repository sync') |
zhoxing-ms
reviewed
Nov 15, 2021
| help='Base64-encoded known_hosts data containing public SSH keys required to access private Git instances') | ||
| c.argument('known_hosts_file', | ||
| arg_group="Auth", | ||
| help='Filepath to known_hosts contents containing public SSH keys required to access private Git instances') |
There was a problem hiding this comment.
Suggested change
| help='Filepath to known_hosts contents containing public SSH keys required to access private Git instances') | |
| help='File path to known hosts contents containing public SSH keys required to access private Git instances') |
zhoxing-ms
reviewed
Nov 15, 2021
| g.custom_command('update', 'flux_config_update', supports_no_wait=True) | ||
| g.custom_command('list', "flux_config_list", table_transformer=fluxconfig_list_table_format) | ||
| g.custom_show_command('show', 'flux_config_show', table_transformer=fluxconfig_show_table_format) | ||
| g.custom_command('delete', 'flux_config_delete', supports_no_wait=True) |
There was a problem hiding this comment.
Do we need to consider adding confirmation=True for the delete operation
There was a problem hiding this comment.
We are using custom delete confirmation, so we are not using the default confirmation as provided by the CLI
zhoxing-ms
reviewed
Nov 15, 2021
| with self.command_group('k8s-configuration flux kustomization', k8s_configuration_fluxconfig_sdk, client_factory=k8s_configuration_fluxconfig_client, is_preview=True) as g: | ||
| g.custom_command('create', 'flux_config_create_kustomization', supports_no_wait=True) | ||
| g.custom_command('update', 'flux_config_update_kustomization', supports_no_wait=True) | ||
| g.custom_command('delete', 'flux_config_delete_kustomization', supports_no_wait=True) |
There was a problem hiding this comment.
Same comment as above, we are using custom confirmation
jonathan-innis
force-pushed
the
k8s-configuration-release-1.2.0
branch
from
2f6d82b
to
65a3927
Compare
zhoxing-ms
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.