Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8s-extension] Release v1.0.4 with SSL secret support for AzureML #4286

Merged

Conversation

jonathan-innis
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

jonathan-innis and others added 30 commits March 10, 2021 13:25
[pull] release from Azure:master
* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import
yuyue9284 and others added 19 commits November 9, 2021 10:17
* populate configuration protected settings for azureml

bump version && add log

fetch connection string only if configuration protected settings are set

update ssl key

* bump the version

* reverse changes on version and HISTORY.rst

* inferenceLoadBalancerHA

Co-authored-by: Yue Yu <yuyu3@microsoft.com>
* Unparallelize tests

* Moved location of pipeline file

* Remove the parallel invoke expression calls

* Add templates to testing
Co-authored-by: Yue Yu <yuyu3@microsoft.com>
Co-authored-by: Jonathan Innis <jonathan.innis.ji@gmail.com>
* Add one more prompt for amlarc extension update

* fix pylint issue

* fix pylint issue

* fix pylint issue

* fix pylint issue

Co-authored-by: Youhua Tu <youhuatu@outlook.com>
Co-authored-by: Youhua Tu <youhuatu@microsoft.com>
* Update appliance API to latest version for identity

* Create a utils file with get parent_api_version

* Fix style errors
* support sslSecret

* fix

* fix error message

Co-authored-by: Jun Min <mijun@microsoft.com>
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 4, 2022

k8s-extension

Copy link
Member

@wangzelin007 wangzelin007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I ask you to add some tests for this release?

@jonathan-innis
Copy link
Contributor Author

May I ask you to add some tests for this release?

Hi @wangzelin007. We have E2E tests that we run in our fork that are not merged into upstream. We are unable to do unit testing because our extension resource relies on pre-created resources in Azure (i.e. a connectedCluster resource)

@zhoxing-ms zhoxing-ms merged commit d573b22 into Azure:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.