-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug for a parameter as a list #6045
Conversation
Thank you for your contribution yadongyaly! We will review the pull request and get back to you soon. |
data migration |
Hi @evelyn-ys , @yonzhan @calvinhzy Can I get a quick review of this smale PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to release a new version, don't forget to update the setup.py
and history.rst
file
Thanks @evelyn-ys for providing the review and comments. i have upgraded the version in those two files. |
[Release] Update index.json for extension [ datamigration ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=46180&view=results |
The PR is to fix a bug for the new CLI commands "az datamigration login-migration".
Local Test:
with this fix, it can migrate logins of source database to the target database.
Below image is the logins of target MI server, the new logins are from the source database by running this CLI command:
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.