Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug for a parameter as a list #6045

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Conversation

yadongyaly
Copy link
Contributor

The PR is to fix a bug for the new CLI commands "az datamigration login-migration".

Local Test:
with this fix, it can migrate logins of source database to the target database.

Below image is the logins of target MI server, the new logins are from the source database by running this CLI command:
image


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 20, 2023
@ghost
Copy link

ghost commented Mar 20, 2023

Thank you for your contribution yadongyaly! We will review the pull request and get back to you soon.

@ghost ghost added Data Migration Auto-Assign Auto assign by bot labels Mar 20, 2023
@ghost ghost requested review from evelyn-ys and calvinhzy March 20, 2023 22:15
@ghost ghost assigned evelyn-ys Mar 20, 2023
@ghost ghost added this to the March 2023 (2023-04-04) milestone Mar 20, 2023
@ghost ghost requested a review from yonzhan March 20, 2023 22:15
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 20, 2023

data migration

@yadongyaly
Copy link
Contributor Author

Hi @evelyn-ys , @yonzhan @calvinhzy

Can I get a quick review of this smale PR?

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to release a new version, don't forget to update the setup.py and history.rst file

@yadongyaly
Copy link
Contributor Author

If you want to release a new version, don't forget to update the setup.py and history.rst file

Thanks @evelyn-ys for providing the review and comments. i have upgraded the version in those two files.

@evelyn-ys evelyn-ys merged commit 9202937 into Azure:main Apr 6, 2023
@azclibot
Copy link
Collaborator

azclibot commented Apr 6, 2023

[Release] Update index.json for extension [ datamigration ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=46180&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot customer-reported Issues that are reported by GitHub users external to the Azure organization. Data Migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants