Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CLI for redisenterprise 2023-03-01-preview using aaz #6048

Merged

Conversation

revanthballa1188
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 21, 2023

redisenterprise

@kairu-ms
Copy link
Contributor

Hi @revanthballa1188, please clean up the commands in generated and manual folders as well. BTW it seems not necessary to update quantum extension

@revanthballa1188
Copy link
Member Author

@kairu-ms , I did not understand what you said? what do you mean by clean up generated folders?
I will remove the quantum folder.

Also, I need help with removing the database_name as required for the commands, It should be taken automatically from the resource as we have just one default now right now

@kairu-ms kairu-ms requested a review from necusjz March 31, 2023 08:24
from codecs import open
from setuptools import setup, find_packages


# HISTORY.rst entry.
VERSION = '0.1.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up version if you want to release it.

@kairu-ms kairu-ms merged commit fb00ea2 into Azure:main May 17, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ redisenterprise ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=55996&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants