[AKS] Add cluster upgrade settings options to aks update #6121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjungaogaogao
requested review from
andyliuliming and
FumingZhang
as code owners
|
Hi @wenjungaogaogao, |
ghost
requested review from
ghost
assigned 
FumingZhang
reviewed
Mar 29, 2023
|
Queued a live test pipeline to verify the change. |
|
AKS |
wenjungaogaogao
force-pushed
the
wenjungao/override
branch
from
b21e149
to
983fd82
Compare
FumingZhang
reviewed
Mar 30, 2023
FumingZhang
reviewed
Mar 30, 2023
There was a problem hiding this comment.
LGTM
Queued a live test pipeline to test the newly add case, passed!
| self.check('upgradeSettings.overrideSettings.controlPlaneOverrides[0]', "IgnoreKubernetesDeprecations"), | ||
| self.exists('upgradeSettings.overrideSettings.until') | ||
| ]) | ||
| self.cmd('aks update --resource-group={resource_group} --name={name} --upgrade-settings IgnoreKubernetesDeprecations --upgrade-override-until 2020-02-22T22:30:17+00:00', checks=[ |
There was a problem hiding this comment.
Maybe it's better to test the disable scenario.
Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
zhoxing-ms
approved these changes
Mar 30, 2023
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=45034&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --resource-group={resource_group} --name={name} --upgrade-settings IgnoreKubernetesDeprecations --upgrade-override-until 2020-02-22T22:30:17+00:00
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.