Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KV Secrets #6154

Merged
merged 9 commits into from
Apr 4, 2023
Merged

Support KV Secrets #6154

merged 9 commits into from
Apr 4, 2023

Conversation

xwang971
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @xwang971,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 31, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@xwang971 xwang971 changed the title Xingjianwang/kvsecrets Support KV Secrets Apr 1, 2023
@xwang971
Copy link
Contributor Author

xwang971 commented Apr 1, 2023

FYI @sanchitmehta

@anthonychu
Copy link
Member

@xwang971 parse_secret_flags is also used by az containerapp create. Can you please add the help text for that too and test it? Thanks.

@xwang971
Copy link
Contributor Author

xwang971 commented Apr 3, 2023

@xwang971 parse_secret_flags is also used by az containerapp create. Can you please add the help text for that too and test it? Thanks.

Hi @anthonychu I didnt add the help text because when create containerapp, secrets with KV settings should not be set. That is because before user identity is assigned or system identity is configured, these secrets polling would fail and containerapps would not be able to be provisioned at cluster. Ideally customers should only update/configure KV secrets after containerapp is provisioned with identity

@anthonychu
Copy link
Member

@xwang971 Good point. Thanks!

xwang971 and others added 2 commits April 3, 2023 14:39
Co-authored-by: Anthony Chu <anthony@anthonychu.ca>
@xwang971
Copy link
Contributor Author

xwang971 commented Apr 3, 2023

@zhoxing-ms @yanzhudd Can I please get review/approval for this PR to catch the public review?

@zhoxing-ms
Copy link
Contributor

Could you please resolve the conflicts?

@xwang971
Copy link
Contributor Author

xwang971 commented Apr 4, 2023

Could you please resolve the conflicts?

Resolved

@xwang971
Copy link
Contributor Author

xwang971 commented Apr 4, 2023

@zhoxing-ms Can I please get this reviewed/approved and get a new version released? This is required for public review.

@zhoxing-ms zhoxing-ms merged commit 6f661a9 into Azure:main Apr 4, 2023
@azclibot
Copy link
Collaborator

azclibot commented Apr 4, 2023

[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=45870&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants