-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support KV Secrets #6154
Support KV Secrets #6154
Conversation
Hi @xwang971, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
FYI @sanchitmehta |
@xwang971 |
Hi @anthonychu I didnt add the help text because when create containerapp, secrets with KV settings should not be set. That is because before user identity is assigned or system identity is configured, these secrets polling would fail and containerapps would not be able to be provisioned at cluster. Ideally customers should only update/configure KV secrets after containerapp is provisioned with identity |
@xwang971 Good point. Thanks! |
Co-authored-by: Anthony Chu <anthony@anthonychu.ca>
@zhoxing-ms @yanzhudd Can I please get review/approval for this PR to catch the public review? |
Could you please resolve the conflicts? |
Resolved |
@zhoxing-ms Can I please get this reviewed/approved and get a new version released? This is required for public review. |
[Release] Update index.json for extension [ containerapp ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=45870&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.