Proxy test + bug fix diagnoser +force del +arm id #6166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/connectedk8s/azext_connectedk8s/_params.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/patch-file.yaml
modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/commands.py modified: src/connectedk8s/azext_connectedk8s/custom.py new file: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
modified: src/connectedk8s/azext_connectedk8s/custom.py renamed: src/connectedk8s/azext_connectedk8s/patch-file.yaml -> src/connectedk8s/azext_connectedk8s/remove_crd_finalizer.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/setup.py
…ensions into force_delete_add
modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml
modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml
….com/rohan-dassani/azure-cli-extensions into timeout_in_crd_deletion_force_delete
modified: src/connectedk8s/azext_connectedk8s/tests/latest/recordings/test_forcedelete.yaml
modified: src/connectedk8s/setup.py
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/_utils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/custom.py modified: src/connectedk8s/azext_connectedk8s/troubleshoot_diagnoser_job_without_proxycert.yaml
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/custom.py
…_nightly_testing
modified: src/connectedk8s/azext_connectedk8s/_troubleshootutils.py modified: src/connectedk8s/azext_connectedk8s/custom.py modified: src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py modified: src/connectedk8s/setup.py
|
Hi @rohan-dassani, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
sirireddy12
reviewed
Apr 4, 2023
src/connectedk8s/azext_connectedk8s/tests/latest/test_connectedk8s_scenario.py
Show resolved
Hide resolved
rohan-dassani
changed the title
sirireddy12
reviewed
Apr 10, 2023
sirireddy12
reviewed
Apr 10, 2023
sirireddy12
reviewed
Apr 10, 2023
zhoxing-ms
reviewed
Apr 10, 2023
| @@ -514,3 +515,49 @@ def test_troubleshoot(self,resource_group): | |||
| # delete the kube config | |||
| os.remove("%s" % (_get_test_data_file(managed_cluster_name + '-config.yaml'))) | |||
|
|
|||
| @live_only() | |||
| @ResourceGroupPreparer(name_prefix='conk8stest', location='eastus2euap', random_name_length=16) | |||
There was a problem hiding this comment.
May I ask why you mark this test as @live_only()?
There was a problem hiding this comment.
All of the tests for our connectedk8s CLI are currently marked as live_only because these tests would not run as recording mode test or integration test because in out connectedk8s connect command in some steps we use some cache to get some values and in recording mode the cache doesnt get recorded and hence we decided to use live_mode only so that we can run the CLI testing pipeline whenever required in live mode only
zhoxing-ms
approved these changes
Apr 11, 2023
|
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=46977&view=results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.