Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fleet] upgrade sdk #6175

Merged
merged 16 commits into from
Apr 13, 2023
Merged

[fleet] upgrade sdk #6175

merged 16 commits into from
Apr 13, 2023

Conversation

pdaru
Copy link
Member

@pdaru pdaru commented Apr 5, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 5, 2023

fleet

@pdaru pdaru marked this pull request as ready for review April 7, 2023 23:58
src/fleet/setup.py Outdated Show resolved Hide resolved
@@ -63,7 +63,7 @@ def update_fleet(cmd,
operation_group="fleets"
)
fleet_patch = fleet_patch_model(tags=tags)
return client.update(resource_group_name, name, None, fleet_patch)
return client.update(resource_group_name, name, fleet_patch, None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the order of the parameters in the python sdk dependent on how they appear in the swagger file?
that is quite annoying...

Is there a way to specify/enforce the order on the sdk generation side with some autorest decorations?

@pdaru
Copy link
Member Author

pdaru commented Apr 11, 2023

all files under vendored_sdks/ are taken directly from the Python sdk and does not warrant a review. only relevant api version is restored, rest are deleted.

src/fleet/HISTORY.rst Show resolved Hide resolved
src/fleet/azext_fleet/__init__.py Outdated Show resolved Hide resolved
src/fleet/setup.py Show resolved Hide resolved
@kairu-ms kairu-ms merged commit b37737f into Azure:main Apr 13, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ fleet ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=47540&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants