Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Containerapp YAML not reading workloadProfileName #6194

Merged
merged 10 commits into from
Apr 14, 2023

Conversation

p-bouchon
Copy link
Contributor

@p-bouchon p-bouchon commented Apr 11, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@ghost ghost requested a review from yonzhan April 11, 2023 17:03
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 11, 2023
@ghost ghost requested a review from wangzelin007 April 11, 2023 17:03
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 11, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested a review from yanzhudd April 11, 2023 17:03
@ghost ghost assigned zhoxing-ms Apr 11, 2023
@ghost ghost added the ContainerApp label Apr 11, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy April 11, 2023 17:03
@p-bouchon p-bouchon marked this pull request as ready for review April 11, 2023 17:28
@jijohn14
Copy link

cli version 0.3.27 is creating invalid request payload by placing workloadProfileName outside properties

Hence got error:
cli.azure.cli.core.util: Response content:
cli.azure.cli.core.util: {"error":{"code":"InvalidRequestContent","message":"The request content was invalid and could not be deserialized: 'Could not find member 'workloadProfileName' on object of type 'ResourceDefinition'. Path 'workloadProfileName', line 1, position 95.'."}}

@p-bouchon
Copy link
Contributor Author

cli version 0.3.27 is creating invalid request payload by placing workloadProfileName outside properties

Hence got error: cli.azure.cli.core.util: Response content: cli.azure.cli.core.util: {"error":{"code":"InvalidRequestContent","message":"The request content was invalid and could not be deserialized: 'Could not find member 'workloadProfileName' on object of type 'ResourceDefinition'. Path 'workloadProfileName', line 1, position 95.'."}}

Confirmed this to be an issue with the YAML file used, the key must be "workloadProfileName", not "workloadprofilename", all keys in the yaml file must be case sensitive

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Apr 13, 2023

@p-bouchon Could you please resolve these CI issues?

@zhoxing-ms zhoxing-ms merged commit d54d48c into Azure:main Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants