-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Containerapp YAML not reading workloadProfileName #6194
Conversation
Thank you for your contribution! We will review the pull request and get back to you soon. |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
cli version 0.3.27 is creating invalid request payload by placing workloadProfileName outside properties Hence got error: |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Outdated
Show resolved
Hide resolved
src/containerapp/azext_containerapp/tests/latest/test_containerapp_workload_profile_commands.py
Show resolved
Hide resolved
Confirmed this to be an issue with the YAML file used, the key must be "workloadProfileName", not "workloadprofilename", all keys in the yaml file must be case sensitive |
@p-bouchon Could you please resolve these CI issues? |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.