Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App create no need to patch again #6200

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Apr 13, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 13, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

@zmssp zmssp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 13, 2023

spring

@zhoxing-ms
Copy link
Contributor

Please add the description of this PR into the HISTORY.rst. If you want to release a new extension version for this PR, please also upgrade the version defined in the setup.py

@zhoxing-ms zhoxing-ms merged commit fa9a9ea into Azure:main Apr 17, 2023
@yuwzho yuwzho deleted the yuwzho/app-create-step-refine branch April 17, 2023 06:15
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ spring ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=48339&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants