Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp fix update --no-wait and --yaml #6209

Merged

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Apr 17, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp update --no-wait --yaml
az containerapp env update --no-wait

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost requested a review from yonzhan April 17, 2023 06:57
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 17, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 17, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost requested review from wangzelin007 and yanzhudd April 17, 2023 06:57
@ghost ghost assigned zhoxing-ms Apr 17, 2023
@ghost ghost added the ContainerApp label Apr 17, 2023
@ghost ghost requested review from zhoxing-ms and jsntcy April 17, 2023 06:57
@Greedygre Greedygre changed the title containerapp fix update --no-wait containerapp fix update --no-wait and --yaml Apr 18, 2023
@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
This pr has been reviewed by zunli. Please help to review and approve, thanks!

@zhoxing-ms zhoxing-ms merged commit ccb9e75 into Azure:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants