-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} feat: ga update for azure monitor for metrics addon (managed prometheus) #6241
Conversation
Hi @bragi92, |
AKS |
src/aks-preview/azext_aks_preview/azuremonitormetrics/amg/link.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test pipeline to verify the change, test passed
src/aks-preview/azext_aks_preview/azuremonitormetrics/amw/defaults.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/azuremonitormetrics/amw/helper.py
Outdated
Show resolved
Hide resolved
src/aks-preview/azext_aks_preview/azuremonitormetrics/azuremonitorprofile.py
Outdated
Show resolved
Hide resolved
…ults.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
…itorprofile.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
…er.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
src/aks-preview/azext_aks_preview/azuremonitormetrics/dc/delete.py
Outdated
Show resolved
Hide resolved
…e.py Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
src/aks-preview/azext_aks_preview/azuremonitormetrics/helper.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=53825&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update -n kaveeshcli22 -g kaveeshcli --enable-azuremonitormetrics --enable-windows-recording-rules
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azuremonitormetrics --enable-windows-recording-rules --azure-monitor-workspace-resource-id "{full_id}" --grafana-resource-id "{full_id}"
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
Description
GA update for Azure Monitor Metrics. The changes for public preview where merged into the az cli extensions repo in the following PR: #5428
The GA update PR for the azure cli repo is here : Azure/azure-cli#26201
Testing Guide
az aks create
andaz aks update
is being updated with the following parameters:type: bool
short-summary: Enable Azure Monitor Metrics Profile
type: string
short-summary: Resource ID of the Azure Monitor Workspace
type: string
short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g. '=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
type: string
short-summary: Comma-separated list of additional Kubernetes label keys that will be used in the resource' labels metric. By default the metric contains only name and namespace labels. To include additional labels provide a list of resource names in their plural form and Kubernetes label keys you would like to allow for them (e.g.'=namespaces=[k8s-label-1,k8s-label-n,...],pods=[app],...)'. A single '' can be provided per resource instead to allow any labels, but that has severe performance implications (e.g. '=pods=[]').
type: string
short-summary: Resource ID of the Azure Managed Grafana Workspace
type: bool
short-summary: Enable Windows Recording Rules when enabling the Azure Monitor Metrics addon
type: bool
short-summary: Disable Azure Monitor Metrics Profile. This will delete all DCRA's associated with the cluster, any linked DCRs with the data stream = prometheus-stream and the recording rule groups created by the addon for this AKS cluster.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.