Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Update AddPRComment.yml #6261

Merged
merged 1 commit into from
May 4, 2023
Merged

Conversation

wangzelin007
Copy link
Member


image
If pr title contains single quotes, bash will report an error when reading github.event.pull_request.title.
According to github doc
We should stored expression in memory and used as a variable, and doesn't interact with the script generation process.
In addition, consider using double quote shell variables to avoid word splitting.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

Hi @wangzelin007,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@ghost ghost added Auto-Assign Auto assign by bot CI labels May 4, 2023
@yonzhan
Copy link
Collaborator

yonzhan commented May 4, 2023

CI

@ghost ghost requested review from yonzhan, jiasli, kairu-ms, jsntcy and bebound May 4, 2023 04:51
@ghost ghost assigned wangzelin007 May 4, 2023
@wangzelin007 wangzelin007 merged commit e8f6316 into Azure:main May 4, 2023
@wangzelin007 wangzelin007 deleted the action_20230504 branch April 5, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants