Add Buildpack source to cloud support + Patch commands #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch list updates
containerapp patch list demo
Use buildpacks for 'az containerapp up --source' no Dockerfile scenario
Fixed bug -- when multiple container apps are listed.
Fixed command usage text
* Adding patch list * Added patch list command * Revert thumbprint arg * Fix bugs * Release ML 2.16.0 (#6259) * Adds IoT Extension Release v0.21.2 (#6264) * Integrated with Harry * Use buildpacks for 'az containerapp up --source' no Dockerfile scenario * Fixed bug * Fixed command usage text * Add warning when Docker client cannot be instantiated --------- Co-authored-by: snehapar9 <snehapar@microsoft.com> Co-authored-by: Neehar Duvvuri <40341266+needuv@users.noreply.github.com> Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com> Co-authored-by: Ryan K <ryan.k@outlook.com> Co-authored-by: daniv-msft <48293037+daniv-msft@users.noreply.github.com> Co-authored-by: Cormac McCarthy <corm@microsoft.com>
- Handle failures caused during 'pack build' prerequisite checks - Output 'pack build' result to stdout - Pull pack CLI from GitHub release
Miscellaneous updates post-Friday demo
* Adding patch list * Added patch list command * Revert thumbprint arg * Fix bugs * Integrated with Harry * Fixed bug * Fixed command usage text * Made managed env optional * Fixed identation * Fixed identation * Made env optional * Remove patch list --------- Co-authored-by: harrli <harrli@microsoft.com> Co-authored-by: Harry Li <110055355+harryli0108@users.noreply.github.com>
Further addressed comments in main PR
@zhoxing-ms Could you please clarify which conflict you're referring to? @snehapar9 resolved a merge conflict with the Workload Profile PR just today. Was it the one you were thinking about? |
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Juliehzl
reviewed
May 17, 2023
Addressed PR comments
Addressed comment and fixed bug
Juliehzl
approved these changes
May 18, 2023
zhoxing-ms
approved these changes
May 18, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the local source to cloud + patching in Container Apps. Building and Patching is done using buildpack. Building is integrated with the Up command, and patching introduces three new CLI commands (cf. below).
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp up
az containerapp patch list
az containerapp patch apply
az containerapp patch interactive
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)=> We have a couple of linting issues we're working on and will send an extra commit for soon, but given the short timeline we decided to send that as a second step.
python scripts/ci/test_index.py -qlocally?About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.