AzCli support for checkpoint operations and added deleteFromHost flag for VM delete #6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mchoubey2021, |
|
Hi @mchoubey2021, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
yanzhudd
reviewed
May 23, 2023
yanzhudd
reviewed
May 23, 2023
yanzhudd
reviewed
May 23, 2023
yanzhudd
reviewed
May 23, 2023
yanzhudd
reviewed
May 23, 2023
yanzhudd
reviewed
May 23, 2023
|
Please add test for the new added commands |
Accepted. Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
|
Added test cases for newly added scenarios |
yanzhudd
reviewed
May 29, 2023
Comment on lines
156
to
171
| self.cmd( | ||
| 'az scvmm vm create-checkpoint -g {resource_group} --name {vm_name} --checkpoint-name {checkpoint_name} --checkpoint-description {checkpoint_description}', | ||
| ) | ||
| alias_sub = self.cmd('az scvmm vm show -g {resource_group} --name {vm_name}').get_output_in_json() | ||
| checkpoint_id = alias_sub['checkpoints'][0]['checkpointId'] | ||
| self.kwargs.update({'checkpoint_id': checkpoint_id}) | ||
|
|
||
| self.cmd( | ||
| 'az scvmm vm restore-checkpoint -g {resource_group} --name {vm_name} --checkpoint-id {checkpoint_id}', | ||
| ) | ||
|
|
||
| self.cmd( | ||
| 'az scvmm vm delete-checkpoint -g {resource_group} --name {vm_name} --checkpoint-id {checkpoint_id}', | ||
| ) | ||
|
|
||
| self.cmd('az scvmm vm delete -g {resource_group} --name {vm_name} --deleteFromHost -y') |
There was a problem hiding this comment.
It is suggested to add some checks for the commands.
There was a problem hiding this comment.
Added checks. Pulled vm states and made checks.
yanzhudd
approved these changes
May 29, 2023
yanzhudd
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az scvmm vm create-checkpoint --subscription contoso-sub
--resource-group contoso-rg --name contoso-vm --checkpoint-name contoso-chkpt-name
--checkpoint-description contoso-chkpt-description
az scvmm vm delete-checkpoint --subscription contoso-sub
--resource-group contoso-rg --name contoso-vm --checkpoint-id checkpoint-guid
az scvmm vm restore-checkpoint --subscription contoso-sub
--resource-group contoso-rg --name contoso-vm --checkpoint-id checkpoint-guid
az scvmm vm delete --subscription contoso-sub
--resource-group contoso-rg --name contoso-avset --deleteFromHost
General Guidelines
azdev style <scvmm>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.