Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ACS Rooms CLI to reference 1.0.0b3 SDK #6322

Merged
merged 5 commits into from
May 28, 2023

Conversation

mikehang-msft
Copy link
Contributor

Updated ACS Rooms CLI to reference 1.0.0b2 SDK
Updated Rooms tests and Recorded test files


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Updated Rooms tests and Recorded test files
@azure-client-tools-bot-prd
Copy link

Hi @mikehang-msft,
If you want to release the new extension version.
Please write the description of changes into HISTORY.rst and update setup.py.

@yonzhan
Copy link
Collaborator

yonzhan commented May 25, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@ghost ghost added the Auto-Assign Auto assign by bot label May 25, 2023
@ghost ghost requested review from yonzhan and FumingZhang May 25, 2023 05:05
@ghost ghost added the AKS label May 25, 2023
@yonzhan yonzhan removed the AKS label May 25, 2023
@mayssamm
Copy link
Member

Also, I believe you need to require a minimum version for the SDK as these changes do not work with previous versions of the rooms python sdk.

@mikehang-msft mikehang-msft changed the title Updated ACS Rooms CLI to reference 1.0.0b2 SDK Updated ACS Rooms CLI to reference 1.0.0b3 SDK May 26, 2023
@kairu-ms kairu-ms merged commit 07a1090 into Azure:main May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants