-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ACS Rooms CLI to reference 1.0.0b3 SDK #6322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated Rooms tests and Recorded test files
Hi @mikehang-msft, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
mayssamm
reviewed
May 25, 2023
Also, I believe you need to require a minimum version for the SDK as these changes do not work with previous versions of the rooms python sdk. |
mikehang-msft
changed the title
Updated ACS Rooms CLI to reference 1.0.0b2 SDK
Updated ACS Rooms CLI to reference 1.0.0b3 SDK
May 26, 2023
mayssamm
approved these changes
May 26, 2023
kairu-ms
approved these changes
May 28, 2023
kairu-ms
reviewed
May 31, 2023
kairu-ms
reviewed
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ACS Rooms CLI to reference 1.0.0b2 SDK
Updated Rooms tests and Recorded test files
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.