Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update incorrect network profile property to monitoring instead … #6405

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: update incorrect network profile property to monitoring instead … #6405

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ Pending
++++++
* Vendor new SDK and bump API version to 2023-05-02-preview.

0.5.144
+++++++
* Fix setup network profile with network observability due to incorrect property

0.5.143
+++++++
* Add `--enable-network-observability` flag to `az aks create` and `az aks update`.
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,7 +2379,7 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:

network_observability = self.context.get_enable_network_observability()
if network_observability is not None:
network_profile.network_monitoring = self.models.NetworkMonitoring(
FumingZhang marked this conversation as resolved.
Show resolved Hide resolved
network_profile.monitoring = self.models.NetworkMonitoring(
enabled=network_observability
)

Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import setup, find_packages

VERSION = "0.5.143"
VERSION = "0.5.144"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down