Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logic] az logic integration-account: Add new command group map to support manage integration account map #6441

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

Jing-song
Copy link
Contributor

@Jing-song Jing-song commented Jun 26, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Jing-song Jing-song requested a review from jsntcy as a code owner June 26, 2023 02:56
@azure-client-tools-bot-prd
Copy link

Hi @Jing-song,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 26, 2023

Logic

@Jing-song Jing-song changed the title [Logic] az logic integration-account: Add new command group map to support manage integration account map * Upgrade SDK to fix deserialization errors [Logic] az logic integration-account: Add new command group map to support manage integration account map Jun 26, 2023
Comment on lines +14 to +42
def logic_workflow_create(cmd, client,
resource_group_name,
name,
definition,
location,
tags=None,
state=None,
endpoints_configuration=None,
access_control=None,
integration_account=None,
integration_service_environment=None):
if 'definition' not in definition:
raise CLIError(str(definition) +
" does not contain a 'definition' key")
workflow = {
'location': location,
'tags': tags,
'state': state,
'endpoints_configuration': endpoints_configuration,
'access_control': definition.get(
'accessControl', access_control),
'integration_account': integration_account,
'integration_service_environment': integration_service_environment,
'definition': definition['definition'],
'parameters': definition.get('parameters', None)
}
return client.create_or_update(resource_group_name=resource_group_name,
workflow_name=name,
workflow=workflow)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's these function used for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating the SDK, the create_or_update parameter was changed, az logic workflow create use it

@kairu-ms kairu-ms merged commit 189c0c0 into Azure:main Jun 29, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ logic ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=68022&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

az logic workflow show fails when AAD Authorization Policies are used Logic app integration account map
5 participants