Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webpubsub] Add kind property to support Web PubSub for Socket.IO #6582

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

zackliu
Copy link
Member

@zackliu zackliu commented Aug 1, 2023


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Add kind in create operation: az webpubsub create --kind

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 1, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️webpubsub
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd webpubsub create cmd webpubsub create added parameter kind

@azure-client-tools-bot-prd
Copy link

Hi @zackliu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link

Hi @zackliu,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 1, 2023

webpubsub

@kairu-ms kairu-ms merged commit 6ba9eac into Azure:main Aug 1, 2023
14 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Aug 1, 2023

[Release] Update index.json for extension [ webpubsub ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=78076&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants