Console color doesn't reset after error when output is redirected

[scabana]

Describe the bug

After some errors, console color doesn't reset. This is similar to #6080.

To Reproduce:

Steps to reproduce the behavior. Note that argument values have been redacted, as they may contain sensitive information.

For example, but not limited to this example:

1. az login
2. wait for token expire
3. az keyvault secret list --vault-name somekeyvault
4. az prints: Get Token request returned http error: 400 and server response: {"error":"interaction_required","error_description":"AADSTS50078: Presented multi-factor authentication has expired due to policies configured by your administrato...
5. echo Hey
6. "Hey" is now red

Expected Behavior

Console color resets to original color.

Environment Summary

Windows-10-10.0.18362-SP0
Python 3.6.6
Installer: MSI

azure-cli 2.6.0 *

Extensions:
aks-preview 0.4.50
azure-devops 0.18.0

Additional Context

❯ $PSVersionTable

Name                           Value
----                           -----
PSVersion                      7.0.0
PSEdition                      Core
GitCommitId                    7.0.0
OS                             Microsoft Windows 10.0.18362
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1
WSManStackVersion              3.0

[yonzhan]

add to S172

[jiasli]

Hi @scabana, are you redirecting the result of az keyvault secret list --vault-name somekeyvault to somewhere else? If so, the only fix is to manually disable color (introduced in #12601) following CLI configuration values and environment variables with the no_color config.

This is a bug with colorama (tartley/colorama#200) out of our control.

[scabana]

Hi,

It's exactly that. I'll rename the issue. Should this issue be kept opened until a proper fix can be provided?

[jiasli]

Yes. The fix microsoft/knack#209 is on its way!

[czmirek]

Got similar issue with az pipelines variable-group list

[jiasli]

@czmirek, this is definitely caused by the colorama bug which is triggered by redirecting the stdout to ConvertTo-Json. microsoft/knack#209 has been merged and the next version of CLI 2.18.0 released by S181 at 2020-01-19 will get rid of this issue.

[jiasli]

This issue has been fixed. Please see #6080 (comment) for the solution.