[Core] Allow disabling color #12601
Merged
[Core] Allow disabling color #12601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
arrownj,
fengzhou-msft,
haroldrandom,
Juliehzl and
qianwens
as code owners
Merged
jiasli
added a commit
that referenced
this pull request
Mar 20, 2020
3 tasks
NVolcz
added a commit
to NVolcz/azure-sdk-for-python
that referenced
this pull request
Jun 27, 2020
The Azure CLI supports colored output by using colorama which resets the color after execution by printing "[0m" if the terminal supports color. This can in some cases cause the AzureCliCredential to fail for example when developing in PyCharm: Azure/azure-cli#9903 Azure CLI allows color output to be disabled by setting the environment variable:AZURE_CORE_NO_COLOR. The PR in azure-cli: Azure/azure-cli#12601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6080, #9903, which are eventually caused by tartley/colorama#200
This PR requires microsoft/knack#171
Azure CLI can now disable color by
AZURE_CORE_NO_COLORenvironment variable toTrueThis PR removes unnecessary Colorama initializations as this is done centrally by Knack. Some command module still initializes Colorama by itself but that won't cause issue. We can gradually remove them in the future.
Whether color should be enabled can now be retrieved at
cli_ctx.enable_color. Using this field, the string literal of these two sentences are changed so that they can be shown without color.