Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Add experimental tag #12543

Merged
merged 3 commits into from
Mar 16, 2020
Merged

[Core] Add experimental tag #12543

merged 3 commits into from
Mar 16, 2020

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Mar 11, 2020

This PR requires microsoft/knack#180

is_experimental=True flag can be used (same as is_preview) with

  1. Command groups
  2. Commands
  3. Arguments

@jiasli jiasli requested a review from mmyyrroonn March 11, 2020 11:14
@jiasli jiasli self-assigned this Mar 11, 2020
@jiasli
is_preview and is_experimental can't be true at the same time
c4cf71b 
Merge branch 'dev' into experimental-tag

# Conflicts:
#	src/azure-cli-core/azure/cli/core/commands/__init__.py
@yonzhan yonzhan added this to the S167 milestone Mar 13, 2020
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 13, 2020

add to S167

@jiasli
Copy link
Member Author

jiasli commented Mar 13, 2020

Changed the behavior to make is_preview and is_experimental mutual-exclusive. If the developer uses both, CLI will errror out:

Error loading command module 'profile': Failed to register command 'account list-locations', is_preview and is_experimental can't be true at the same time

@jiasli jiasli changed the base branch from dev to knack-adoption March 16, 2020 13:00
@jiasli
Merge branch 'knack-adoption' into experimental-tag
2ba2b5b 
# Conflicts:
#	src/azure-cli-core/azure/cli/core/commands/__init__.py
@jiasli jiasli merged commit 0ce8289 into Azure:knack-adoption Mar 16, 2020
@jiasli jiasli mentioned this pull request Mar 16, 2020
Merged
jiasli added a commit that referenced this pull request Mar 20, 2020
@jiasli
{Core} Knack adoption (#12604)
decf463 
* Allow disabling color (#12601)

* Support --only-show-errors (#12544)

* Add experimental tag (#12543)

* Move yaml output to Knack (#12603)
@jiasli jiasli deleted the experimental-tag branch April 16, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arrownj arrownj Awaiting requested review from arrownj

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@haroldrandom haroldrandom Awaiting requested review from haroldrandom

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

@qianwens qianwens Awaiting requested review from qianwens

@mmyyrroonn mmyyrroonn Awaiting requested review from mmyyrroonn

Assignees

@jiasli jiasli

Labels
do-not-merge
Projects
None yet
Milestone
S167
Development

Successfully merging this pull request may close these issues.
2 participants
@jiasli @yonzhan