Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of MSI version 2021-09-30-preview #22112

Closed
arndt-s opened this issue Apr 19, 2022 · 19 comments · Fixed by #22284 or #22519
Closed

Release of MSI version 2021-09-30-preview #22112

arndt-s opened this issue Apr 19, 2022 · 19 comments · Fixed by #22284 or #22519
Assignees
Labels

Comments

@arndt-s
Copy link

arndt-s commented Apr 19, 2022

Resource Provider
MSI / Managed Identity

Description of Feature or Work Requested
We would like to release a new preview version that reflects new MSI api "listAssociatedResources" introduced in swagger (link below)

Minimum API Version Required
2021-09-30-preview

Swagger Link
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/msi/resource-manager/Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json

Target Date
May 2022

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 19, 2022

Managed Identity

@zhoxing-ms
Copy link
Contributor

@arndt-s Could you please provide the PR of Swagger change?
And may I ask are there any requirements for new CLI commands and parameters? Or do we just need to upgrade the api-version to 2021-09-30-preview?

@arndt-s
Copy link
Author

arndt-s commented Apr 20, 2022

@zhoxing-ms this is the PR: Azure/azure-rest-api-specs#18123 (review)

We need the have the "listAssociatedResources" capability added to CLI. It's an entirely new POST request.

@Jing-song Jing-song self-assigned this Apr 21, 2022
@Jing-song
Copy link
Contributor

Jing-song commented Apr 21, 2022

@arndt-s The new SDK has not been released to pypi yet https://pypi.org/project/azure-mgmt-msi/#history

@arndt-s
Copy link
Author

arndt-s commented Apr 25, 2022

@PARADISSEEKR it has been released: https://pypi.org/project/azure-mgmt-msi/6.0.0b2/
The PR for the python SDK is https://github.com/Azure/sdk-release-request/issues/2570

@yonzhan yonzhan closed this as completed Apr 25, 2022
@yonzhan yonzhan reopened this Apr 25, 2022
@Jing-song
Copy link
Contributor

Jing-song commented Apr 28, 2022

@PARADISSEEKR it has been released: https://pypi.org/project/azure-mgmt-msi/6.0.0b2/ The PR for the python SDK is Azure/sdk-release-request#2570

Hi @arndt-s For identity, do we need to support multiapi? if so, CLI cannot use it(6.0.0) due to inconsistency between api version and file name, please release the correct version, if not, we can remove multiapi and use 6.0.0b2.
image
image

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Apr 28, 2022

I guess the inconsistency between the api-version and folder name is caused by a mistake from this PR Azure/azure-rest-api-specs#18123 (comment) @msyyc Could you please help confirm it?

@arndt-s
Copy link
Author

arndt-s commented Apr 28, 2022

Fix is on the way: Azure/azure-rest-api-specs#18850

@msyyc
Copy link
Member

msyyc commented Apr 29, 2022

Hi, it will be fixed in Azure/azure-rest-api-specs#18860 and we will release a new version soon: https://github.com/Azure/sdk-release-request/issues/2750

@arndt-s
Copy link
Author

arndt-s commented May 18, 2022

@PARADISSEEKR does your change add "listAssociatedResources" method to the MSI commands? I can only see that the api version got bumped up.

@arndt-s
Copy link
Author

arndt-s commented May 18, 2022

@PARADISSEEKR another thing I wanted to clarify: Will calls going to MSI control plane still be using 2018-11-30 by default and only 2021-09-30-preview when specified?

@zhoxing-ms zhoxing-ms reopened this May 18, 2022
@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 18, 2022

does your change add "listAssociatedResources" method to the MSI commands? I can only see that the api version got bumped up.

@PARADISSEEKR Please remember to add new commands for method listAssociatedResources to identity module

another thing I wanted to clarify: Will calls going to MSI control plane still be using 2018-11-30 by default and only 2021-09-30-preview when specified?

@arndt-s At present, the api-version in the official CLI can only set a fixed version in the RP level, it does not support allowing users to specify the api-version. Therefore, the api-version for MSI currently used is 2021-09-30-preview

@arndt-s
Copy link
Author

arndt-s commented May 18, 2022

@zhoxing-ms this API version is in public preview and for example not available in sovereign clouds yet. Will the release of azure-cli be a preview release or an official one?

@arndt-s
Copy link
Author

arndt-s commented May 19, 2022

@zhoxing-ms this API version is in public preview and for example not available in sovereign clouds yet. Will the release of azure-cli be a preview release or an official one?

@zhoxing-ms if release of azure-cli will be official we cannot have the preview version on it as all calls regarding MSI will fail in regions where preview apiVersion is not available.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 19, 2022

@arndt-s We only upgraded the api-version in the latest profile used by public cloud, which will not affect the api-version used by Azure Stack or other sovereign clouds

@arndt-s
Copy link
Author

arndt-s commented May 19, 2022

Thank you for clarification.

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented May 19, 2022

@arndt-s We release the official CLI only for public cloud, I‘d like to confirm whether there are regions that are not available in the public cloud?

@zhoxing-ms
Copy link
Contributor

In addition, we have added PR #22519 to add list-resources command

@arndt-s
Copy link
Author

arndt-s commented May 19, 2022

@zhoxing-ms I can confirm that all regions in public can serve traffic for 2021-09-30-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment