[Hub Generated] Public private branch 'msi-associated-resources-preview-api-2021-09-30' #18123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2018-11-30 to version 2021-09-30-preview
|
The PR is created based on the updates in the private branch. The updates in the PR has already been reviewed and approved with this PR Azure/azure-rest-api-specs-pr/4969 |
|
Hi, @arndt-s Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com |
|
[Call for Action] To better understand Azure service dev/test scenario, and support Azure service developer better on Swagger and REST API related tests in early phase, please help to fill in with this survey https://aka.ms/SurveyForEarlyPhase. It will take 5 to 10 minutes. If you already complete survey, please neglect this comment. Thanks. |
Swagger Validation Report
|
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.ManagedIdentity/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L70 |
|
The schema 'Identity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L411 |
|
The schema 'IdentityUpdate' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L427 |
|
The schema 'SystemAssignedIdentity' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L463 |
|
The schema 'UserAssignedIdentitiesListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L618 |
|
The schema 'CloudError' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L634 |
|
The schema 'CloudErrorBody' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L644 |
|
The schema 'OperationDisplay' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L686 |
|
The schema 'OperationListResult' is considered an object but without a 'type:object', please add the missing 'type:object'. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L712 |
|
Missing identifier id in array item property Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L659 |
|
Missing identifier id in array item property Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L716 |
| Guid used in model definition 'SystemAssignedIdentityProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L507 |
|
| Guid used in model definition 'UserAssignedIdentityProperties' for property 'tenantId'. Usage of Guid is not recommanded. If GUIDs are absolutely required in your service, please get sign off from the Azure API review board. Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L537 |
|
| Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: MsiOperationsList Location: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L74 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️~[Staging] ApiReadinessCheck succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️⚠️Cross-Version Breaking Changes: 3 Warnings warning [Detail]
- Compared Swaggers (Based on Oad v0.9.3)
- current:preview/2021-09-30-preview/ManagedIdentity.json compared with base:stable/2018-11-30/ManagedIdentity.json
- current:preview/2021-09-30-preview/ManagedIdentity.json compared with base:preview/2015-08-31-preview/ManagedIdentity.json
| Rule | Message |
|---|---|
| The new version is missing a definition that was found in the old version. Was 'IdentityProperties' removed or renamed? New: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L410:3 Old: Microsoft.ManagedIdentity/preview/2015-08-31-preview/ManagedIdentity.json#L353:3 |
|
| The new version has a different 'allOf' property than the previous one. New: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L313:13 Old: Microsoft.ManagedIdentity/preview/2015-08-31-preview/ManagedIdentity.json#L256:13 |
|
| The new version is missing a property found in the old version. Was 'clientSecretUrl' renamed or removed? New: Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json#L536:7 Old: Microsoft.ManagedIdentity/preview/2015-08-31-preview/ManagedIdentity.json#L413:7 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️️✔️SDK Track2 Validation succeeded [Detail] [Expand]
Validation passes for SDKTrack2Validation
- The following tags are being changed in this PR
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
Swagger Generation Artifacts
|
This was referenced Mar 7, 2022
openapi-workflow-bot
bot
added
the
WaitForARMFeedback
|
Hi, @arndt-s your PR are labelled with WaitForARMFeedback. A notification email will be sent out shortly afterwards to notify ARM review board(armapireview@microsoft.com). |
mentat9
reviewed
Mar 8, 2022
...i/resource-manager/Microsoft.ManagedIdentity/preview/2021-09-30-preview/ManagedIdentity.json
Show resolved
Hide resolved
|
Signed off from ARM side, but be sure your API handles the SDK behavior. |
mentat9
added
ARMSignedOff
lirenhe
approved these changes
Mar 11, 2022
|
@arndt-s, please help to resolve the comment and then i will merge this PR. |
|
@arndt-s - ARM review of your PR is complete and signed off. ARM reviewers only review and sign off REST APIs from ARM perspective. Only the SDK team is authorized to approve and merge PRs. Please work with your assigned reviewer (@lirenhe) to complete your PR. If you push changes the REST layer that require another ARM signoff, you can add the WaitForARMFeedback label to your PR (if the automation doesn't do it) and the current week's ARM review oncall will be notified and pick up ARM review for your PR. |
arndt-s
deleted the
published/natronq/azure-rest-api-specs-pr/msi-associated-resources-preview-api-2021-09-30
branch
zhoxing-ms
reviewed
Apr 28, 2022
Comment on lines
+29
to
+33
| tag: package-preview-2021-09 | ||
| ``` | ||
|
|
||
|
|
||
| ### Tag: package-preview-2021-09 |
There was a problem hiding this comment.
Public private branch 'msi-associated-resources-preview-api-2021-09-30'
I guess the inconsistency between the api-version and folder name is caused by the tag name of the SDK should be added with the date information, such as package-preview-2021-09-30, otherwise the folder name of the SDK version will default to 2021_09_01
There was a problem hiding this comment.
I created #18850 for the fix
FredericHeem
pushed a commit
to grucloud/azure-rest-api-specs
that referenced
this pull request
May 16, 2022
…ew-api-2021-09-30' (Azure#18123) * Adds base for updating Microsoft.ManagedIdentity from version stable/2018-11-30 to version 2021-09-30-preview * Updates readme * Updates API version in new specs and examples * Associated resources preview API * Fix linter issues * Use POST instead of GET * Fix example * fix skiptoken parameter to lowercase * fix formats in examples * replace empty with random GUIDs Co-authored-by: Yannick <6431099+natronq@users.noreply.github.com> Co-authored-by: Yannick Pobiega <ypobiega@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR generated at OpenAPI Hub. You can view your work branch via this link.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that label "WaitForARMFeedback" will be added automatically to begin ARM API Review. Failure to comply may result in delays to the manifest.
-[ ] To review changes efficiently, ensure you are using OpenAPIHub to initialize the PR for adding a new version. More details, refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If any of the following scenarios apply to the PR, request approval from the Breaking Change Review Board as defined in the Breaking Change Policy.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.