Monitor metrics alerts: Support custom namespace. Add guidance for using ANTLR code-gen. #10108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/azure-cli/azure/cli/command_modules/monitor/grammar/MetricAlertConditionValidator.py
Outdated
Show resolved
Hide resolved
|
|
||
| # pylint: disable=all | ||
|
|
||
| # Generated from MetricAlertCondition.g4 by ANTLR 4.7.1 |
There was a problem hiding this comment.
we probably still need the license head
AnanyShah
reviewed
Aug 1, 2019
src/azure-cli/azure/cli/command_modules/monitor/grammar/MetricAlertCondition.g4
Outdated
Show resolved
Hide resolved
|
@yugangw-msft issues addressed. Should be ready for merge |
yugangw-msft
approved these changes
Aug 1, 2019
|
@tjprescott, can you please resolve the conflict and merge? |
|
I need to create metric alert in azure CLI: Can you please suggest if we can use custom condition for az monitor metrics alert create. I wanted to use the custom metric "traces/count" with "message" for trace details to be checked. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9460.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.