{SQL} fix az sql server ad-admin update , az sql server ad-admin create calls #12541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding test recording too.
|
add to S167 |
jaredmoo
reviewed
Mar 11, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jaredmoo
reviewed
Mar 12, 2020
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
jaredmoo
reviewed
Mar 12, 2020
jaredmoo
approved these changes
Mar 12, 2020
|
Facing an ADO error for now, will refresh any time if ADO available |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@amolagar5 CI is back, please take care of the code style problem. |
1 similar comment
|
@amolagar5 CI is back, please take care of the code style problem. |
|
@haroldrandom Fixed the styling issues, please take a look when possible. |
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.