[AKS] BREAKING CHANGE: aks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds
#26356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
bot
added this to the May 2023 (2023-05-23) - For Build (Breaking change release) milestone
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
wanlonghenry
changed the title
wanlonghenry
changed the title
wanlonghenry
changed the title
wanlonghenry
changed the title
wanlonghenry
changed the title
ganga1980
reviewed
May 8, 2023
ganga1980
reviewed
May 8, 2023
ganga1980
reviewed
May 9, 2023
wanlonghenry
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
Please note that the GET Location request is missing from the recording file. Please use |
|
@zhoxing-ms thank you for the detailed guide, I just updated the recording file and all checks have passed, could you please review the whole PR when available, thanks! |
zhoxing-ms
reviewed
May 16, 2023
ganga1980
reviewed
May 16, 2023
|
@wanlonghenry Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (07-04) |
|
|
|
@zhoxing-ms I addressed all comments and also attached the test screenshots, please review and check, thank you! |
zhoxing-ms
changed the title
aks create: Change --enable-msi-auth-for-monitoring default to true and add check for airgap clouds
zhoxing-ms
changed the title
aks create: Change --enable-msi-auth-for-monitoring default to true and add check for airgap cloudsaks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds
zhoxing-ms
changed the title
aks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap cloudsaks create: Change the default value of --enable-msi-auth-for-monitoring to true and add check for airgap clouds
zhoxing-ms
approved these changes
May 18, 2023
This was referenced May 22, 2023
3 tasks
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
…nable-msi-auth-for-monitoring` to true and add check for airgap clouds (Azure#26356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.