Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cosmos DB] az cosmosdb create/update: Add support for minimum allowed TLS version and burst capacity configuration #27322

Merged

Conversation

AdrianSibajaRetana
Copy link
Contributor

Related command
az cosmosdb create

Description
Removed preview parameters and added test for new property.

Testing Guide
Added test for CMK status.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 5, 2023

🔄AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.10
️✔️3.9
️✔️ams
️✔️latest
️✔️3.10
️✔️3.9
️✔️apim
️✔️latest
️✔️3.10
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.10
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.10
️✔️3.9
️✔️aro
️✔️latest
️✔️3.10
️✔️3.9
️✔️backup
️✔️latest
️✔️3.10
️✔️3.9
️✔️batch
️✔️latest
️✔️3.10
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.10
️✔️3.9
️✔️billing
️✔️latest
️✔️3.10
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.10
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.10
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.10
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.10
️✔️3.9
️✔️config
️✔️latest
️✔️3.10
️✔️3.9
️✔️configure
️✔️latest
️✔️3.10
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.10
️✔️3.9
️✔️container
️✔️latest
️✔️3.10
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.10
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.10
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️dla
️✔️latest
️✔️3.10
️✔️3.9
️✔️dls
️✔️latest
️✔️3.10
️✔️3.9
️✔️dms
️✔️latest
️✔️3.10
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.10
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.10
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.10
️✔️3.9
️✔️find
️✔️latest
️✔️3.10
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.10
️✔️3.9
️✔️identity
️✔️latest
️✔️3.10
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.10
️✔️3.9
️✔️lab
️✔️latest
️✔️3.10
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.10
️✔️3.9
️✔️maps
️✔️latest
️✔️3.10
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.10
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.10
️✔️3.9
🔄mysql
🔄latest
️✔️3.10
🔄3.9
️✔️netappfiles
️✔️latest
️✔️3.10
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.10
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.10
️✔️3.9
️✔️profile
️✔️latest
️✔️3.10
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.10
️✔️3.9
️✔️redis
️✔️latest
️✔️3.10
️✔️3.9
️✔️relay
️✔️latest
️✔️3.10
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️role
️✔️latest
️✔️3.10
️✔️3.9
️✔️search
️✔️latest
️✔️3.10
️✔️3.9
️✔️security
️✔️latest
️✔️3.10
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.10
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.10
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.10
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.10
️✔️3.9
️✔️sql
️✔️latest
️✔️3.10
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.10
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.10
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️util
️✔️latest
️✔️3.10
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 5, 2023

⚠️AzureCLI-BreakingChangeTest
⚠️cosmosdb
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter enable_burst_capacity
⚠️ 1006 - ParaAdd cosmosdb create cmd cosmosdb create added parameter minimal_tls_version
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter enable_burst_capacity
⚠️ 1006 - ParaAdd cosmosdb update cmd cosmosdb update added parameter minimal_tls_version

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 5, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added CosmosDB az cosmosdb Auto-Assign Auto assign by bot labels Sep 5, 2023
@AdrianSibajaRetana AdrianSibajaRetana changed the title Added CMK related changes to stable 0915 version. Adding 9-15-stable CosmosDB changes Sep 5, 2023
@AdrianSibajaRetana AdrianSibajaRetana marked this pull request as draft September 5, 2023 18:43
When using the key-uri parameter on an update, the non-CMK to CMK migration is triggered. This workflow is independent from the CMK provisioning workflow and is currently in preview.
@AdrianSibajaRetana AdrianSibajaRetana changed the title Adding 9-15-stable CosmosDB changes [Cosmos DB] Adding 9-15-stable CosmosDB changes Sep 19, 2023
@AdrianSibajaRetana AdrianSibajaRetana changed the title [Cosmos DB] Adding 9-15-stable CosmosDB changes [Cosmos DB] Add 9-15-stable CosmosDB changes Sep 19, 2023
@AdrianSibajaRetana
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 27322 in repo Azure/azure-cli

@AdrianSibajaRetana AdrianSibajaRetana marked this pull request as ready for review September 26, 2023 14:37
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 3, 2023

Please fix CI issues.

@AdrianSibajaRetana
Copy link
Contributor Author

@yonzhan CI changes have been fixed. Can you please approve?

@AdrianSibajaRetana
Copy link
Contributor Author

@calvinhzy, @evelyn-ys, @jsntcy, @kairu-ms, @necusjz, and/or @wangzelin007. Can any of you folks review the changes as well please?

@pjohari-ms
Copy link
Member

@evelyn-ys Can you review and merge this PR? Thanks.

@evelyn-ys evelyn-ys changed the title [Cosmos DB] Add 9-15-stable CosmosDB changes [Cosmos DB] az cosmosdb create/update: Add support for minimum allowed TLS version and burst capacity configuration Oct 10, 2023
@evelyn-ys evelyn-ys merged commit 0a3058e into Azure:dev Oct 10, 2023
54 checks passed
carjackson-msft added a commit to carjackson-msft/azure-cli-extensions that referenced this pull request Feb 29, 2024
carjackson-msft added a commit to carjackson-msft/azure-cli-extensions that referenced this pull request Feb 29, 2024
evelyn-ys pushed a commit to Azure/azure-cli-extensions that referenced this pull request Mar 20, 2024
…#7271)

* add new sdk

* update version

* update sdk

* cli changes for PRPP

* variable name fix, added test case

* Add mode in copy job

(cherry picked from commit a28144517ad4022098561e83d8607c93933dd36c)

* Add complete job API

(cherry picked from commit 3d721cb)
(cherry picked from commit f4e6f01f99eb1299e8c536423f074e9832b71e16)

* Add test

* history.rst changes

* Add history

* Introduce disable_ttl parameter

* Syntax error fixes

* Update tests

* Fix syntax error

* Change test location to WestCentralUS where 0201 batch1 is completed, add remaining asserts, rerecordings

* Update history file

* Changed cluster deallocate force input to string

* add missing changes from stable Azure/azure-cli#26226

* add stable changes https://github.com/Azure/azure-cli/pull/27175/files

* https://github.com/Azure/azure-cli/pull/27322/files

* add missing stable changes from https://github.com/Azure/azure-cli/pull/26392/files

* Revert "https://github.com/Azure/azure-cli/pull/27322/files"

This reverts commit f779e16.

* add missing stable changes for minimal tls version from Azure/azure-cli#27322

* nit

* Revert "nit"

This reverts commit d4f4abe.

* Revert "add missing stable changes for minimal tls version from Azure/azure-cli#27322"

This reverts commit be4709e.

* fix style checl

* Address multi character short flag issue

* Add missing parameters

* Fix syntax issue

* Remove short flag

* fix test

* poc for test changes

* inital changes in custom.py

* removing recordings

* changes in params as well as test and recording for sql ntbr flow

* fixing imports

* fixing test

* fixing recordings

* config name change from --enable-per-region-per-partition-autoscale to --enable-prpp-autoscale

* re-record tests

* nit style

* Revert "fixing recordings"

This reverts commit ea5c847.

* Revert "removing recordings"

This reverts commit 583371c.

* fixing incorrect merge

* Added test

* 6 out of 8 test failures

* fixing remaining 2 tests

* fixing style issues

* Update HISTORY.rst to reflect changes ported from stable CLI

* re-record cassandra tests

* Update version to 1.0.0 due to breaking changes

* azdev style fixes

* azdev style fixes

* azdev style fixes

* azdev style fixes

* azdev style fixes

* azdev style fixes

* Update HISTORY.rst version to 1.0.0

---------

Co-authored-by: Kushal Warke <kuwarke@microsoft.com>
Co-authored-by: Nitesh Vijay <niteshvijay@microsoft.com>
Co-authored-by: Nitesh Vijay <niteshvijay1995@gmail.com>
Co-authored-by: Min Ho Kang <minhokang@microsoft.com>
Co-authored-by: drewkaufmann <drewkaufmann@microsoft.com>
Co-authored-by: Vivek Agarwal (from Dev Box) <agarwalvivek@microsoft.com>
Co-authored-by: AgarwalVivek <vagarwal1@hawk.iit.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CosmosDB az cosmosdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants