Preview extension notation & Simple default view for extension list-a… #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View a preview at https://prompt.ws/r/Azure/azure-cli/5882 |
derekbekoe
added
the
Extensions
|
Some screenshots:
|
|
I'll let Troy and Willie comment on the code itself, but from the screenshot my only feedback is it might make sense to put the Preview and Installed columns to the left of summary (closer to the name) because there can be a lot of whitespace in the summary and it can be tricky to follow across the row to see which extension that random "True" floating in space refers to. |
…vailable - Show message for extensions marked as preview on -h
derekbekoe
force-pushed
the
feature/ext-preview-flag
branch
from
2b1e86c
to
b04089d
Compare
williexu
reviewed
Mar 22, 2018
| 'preview': latest['metadata'].get(EXT_METADATA_ISPREVIEW, False), | ||
| 'installed': installed | ||
| }) | ||
| return results |
There was a problem hiding this comment.
Do we have a test for this?
There was a problem hiding this comment.
I do have some tests but not for these changes...
I will take a look at adding tests... 👍
|
@williexu can you take another look? |
williexu
approved these changes
Mar 22, 2018
troydai
approved these changes
Mar 22, 2018
haroldrandom
added
the
Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview extension notation & Simple default view for extension list-available
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.