Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Change Feed: Adds change feed retention policy to container configuration #2020

Merged
merged 37 commits into from
Jan 6, 2021

Conversation

ealsur
Copy link
Member

@ealsur ealsur commented Nov 19, 2020

Description

This PR adds the Change Feed policy retention configuration to a container. Change Feed retention is used in Full Fidelity Change Feed and allows the user to define the time length during which deleted documents will be retained in the Change Feed.

Creating a Container with change feed retention

ContainerProperties containerProperties = new ContainerProperties("myContainer", "/pk");
containerProperties.ChangeFeedPolicy.FullFidelityRetention = TimeSpan.FromMinutes(5);

CosmosContainerResponse containerCreateResponse = await database.CreateContainerAsync(containerProperties, 5000);

With the Fluent extensions:

string containerName = "myContainer";
string partitionKeyPath = "/pk";

ContainerResponse containerResponse =
    await database.DefineContainer(containerName, partitionKeyPath)
        .WithChangeFeedPolicy(retention: TimeSpan.FromMinutes(5))
            .Attach()
        .CreateAsync();

Type of change

  • New feature (non-breaking change which adds functionality)

@ealsur ealsur self-assigned this Nov 19, 2020
j82w
j82w previously approved these changes Jan 6, 2021
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview gates on JAVA availability

@ealsur ealsur changed the title [Preview] Change Feed: Adds change feed retention policy to container configuration [Internal] Change Feed: Adds change feed retention policy to container configuration Jan 6, 2021
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

@fazil1987
Copy link

fazil1987 commented Jan 20, 2023

@ealsur,

ChangefeedPolicy property is public only in preview mode, when can we expect this to be public in all modes?

@ealsur
Copy link
Member Author

ealsur commented Jan 20, 2023

@fazil1987 This is related to the Full Fidelity feature, and it is currently in public preview. GA of SDK APIs aligns with GA of the service feature, when the service feature announces GA, then so will the SDKs. I don't have any specific dates that I am aware of and can share.

@fazil1987
Copy link

fazil1987 commented Jan 23, 2023

Thanks for the info @ealsur. Just want to know, is this feature stable and reliable enough to use it in production given this is been there for 2 years? Also would like to know what's stopping this feature from getting into GA given PR was merged 2 years ago? Is it overlooked?

@ealsur
Copy link
Member Author

ealsur commented Jan 23, 2023

@fazil1987 Features like this are driven by the service, not the client SDKs. Client SDKs just implement the APIs that customers can call to access these features, hence, the reason for a particular feature to be still in preview or when it will GA is directly defined by the service feature (the SDK will just move these APIs to the GA package once GA is achieved). How long until this feature is GA or if the feature is reliable to be used in production is not something that can be addressed in this repository because it is not directly related to the code here. I would not advise using any preview feature in production until the team explicitly states otherwise.
I would think that once the feature is ready, it will be announced through the public channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants