Change Feed Processor: Fixes StartTime not being correctly applied. Introduced in PR #1933

[ealsur]

Pull Request Template

Description

#1725 introduced a regression on the time format used when sending the desired start time to the backend.

The bug is that ChangeFeedStartFromRequestOptionPopulator is now using a different format for the date.

On 3.13.0 it was using PopulateStartFromRequestOptionVisitor that was using:

this.requestMessage.Headers.Add(
    HttpConstants.HttpHeaders.IfModifiedSince,
    startFromTime.StartTime.ToString("r", CultureInfo.InvariantCulture));

Which yields, for example Wed, 02 Dec 2020 21:27:36 GMT

On 3.15.0 it is using

this.requestMessage.Headers.Add(
    HttpConstants.HttpHeaders.IfModifiedSince,
    startFromTime.StartTime.ToString("o", CultureInfo.InvariantCulture));

Which yields, for example 2020-12-02T21:29:29.6812357Z

The backend seems to be discarding the header due to the bad format.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Closing issues

Closes #2031

[FabianMeiswinkel]

Thanks!

[ghost]

Closing due to in-activity, pease feel free to re-open.