Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.30.0: Adds new SDK versions and contract files #3390

Merged
merged 5 commits into from
Aug 19, 2022

Conversation

kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Aug 18, 2022

Pull Request Template

Description

This bumps the SDK version from 3.29.0 to 3.30.0. Please see the below changes in the GA public contract.

contract_diff_3_29_0_and_3_30_0_aug_19
Also highlighted below are the preview contract changes.

contract_diff_3_29_0_preview_and_3_30_0_preview_aug_19

Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments

changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
changelog.md Outdated Show resolved Hide resolved
@kirankumarkolli
Copy link
Member

  • For TTL expired documents what's expected on ChangeFeedMetadata? (ex: OperationType will be delete and TTLExpire=true). Please cover it code documentaion.
  • TimeToLiveExpired: How about 'IsTimeToLiveExpired'?

changelog.md Outdated Show resolved Hide resolved
@philipthomas-MSFT
Copy link
Contributor

@philipthomas-MSFT
Copy link
Contributor

  • For TTL expired documents what's expected on ChangeFeedMetadata? (ex: OperationType will be delete and TTLExpire=true). Please cover it code documentaion.
  • TimeToLiveExpired: How about 'IsTimeToLiveExpired'?

@kirankumarkolli
AFAIK, yes, if the OperationType is 'deleted' then the TimeToLiveExpired will be 'true'.
Also, are you suggesting a refactor to change TimeToLiveExpired to 'IsTimeToLiveExpired'?

changelog.md Show resolved Hide resolved
@kundadebdatta kundadebdatta force-pushed the users/kundadebdatta/version/3.30.0 branch from 243f97a to f4ba56f Compare August 19, 2022 20:25
@kundadebdatta
Copy link
Member Author

I have updated the contract to reflect the correct naming convention.

@kundadebdatta kundadebdatta marked this pull request as ready for review August 19, 2022 21:19
@ealsur ealsur merged commit f699ced into master Aug 19, 2022
@ealsur ealsur deleted the users/kundadebdatta/version/3.30.0 branch August 19, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants