Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request & response clone #209

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Add support for request & response clone #209

merged 2 commits into from
Jan 11, 2024

Conversation

ejizba
Copy link
Contributor

@ejizba ejizba commented Jan 10, 2024

Just mirroring the existing "clone" methods already supported in undici/fetch. Per the docs, "the main reason clone() exists is to allow multiple uses of body objects (when they are one-use only.)"

Fixes #207

@ejizba ejizba requested a review from castrodd January 10, 2024 00:54
@ejizba ejizba merged commit aa9068d into v4.x Jan 11, 2024
11 checks passed
@ejizba ejizba deleted the ej/clone branch January 11, 2024 20:40
@restfulhead
Copy link

@ejizba Thank you for adding this. Any chance this could be released to NPM?

@ejizba
Copy link
Contributor Author

ejizba commented Jan 16, 2024

Hi @restfulhead our plan is to do a release at the end of January, so should be out pretty soon

@Sarabadu
Copy link

Hi @ejizba, thank for adding this will help us a lot.
it is possible to have an alpha build to start testing it? we are building some middleware and we didn't find a way to workaround this yet

@ejizba
Copy link
Contributor Author

ejizba commented Jan 19, 2024

@Sarabadu You could download the tgz file from our latest v4.x branch build: https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=159678&view=artifacts&pathAsName=false&type=publishedArtifacts

(download "drop.zip", unzip that, and from your repo do npm install <path to azure-functions-4.1.0-alpha.20240111.3.tgz>)

@restfulhead
Copy link

Hi @restfulhead our plan is to do a release at the end of January, so should be out pretty soon

@ejizba Any updates regarding the release?

Btw, the link https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=159678&view=artifacts&pathAsName=false&type=publishedArtifacts takes me to an almost empty page. I don't see any file to download.

@ejizba
Copy link
Contributor Author

ejizba commented Jan 30, 2024

Hi we just released v4.2.0 with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to reference HttpRequest body in hooks
4 participants