-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed jackson transient serialization bug and handled HTTP status 204 in HTTPResponseWrapper #310
Merged
AsafMah
merged 9 commits into
master
from
feature/fix-jackson-transient-serialization-bug
Jul 17, 2023
Merged
fixed jackson transient serialization bug and handled HTTP status 204 in HTTPResponseWrapper #310
AsafMah
merged 9 commits into
master
from
feature/fix-jackson-transient-serialization-bug
Jul 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com:Azure/azure-kusto-java into feature/fix-jackson-transient-serialization-bug
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
============================================
- Coverage 56.24% 56.19% -0.06%
Complexity 699 699
============================================
Files 103 103
Lines 3737 3739 +2
Branches 386 387 +1
============================================
- Hits 2102 2101 -1
- Misses 1464 1467 +3
Partials 171 171
|
tanmaya-panda1
changed the title
fixed jackson transient serialization bug
fixed jackson transient serialization bug and handled HTTP status 204 in HTTPResponseWrapper
Jul 14, 2023
AsafMah
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
ag-ramachandran
approved these changes
Jul 16, 2023
data/src/main/java/com/microsoft/azure/kusto/data/auth/HttpResponseWrapper.java
Outdated
Show resolved
Hide resolved
…hub.com:Azure/azure-kusto-java into feature/fix-jackson-transient-serialization-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Changed
Fixed
@JsonIgnore
no longer works for transient backing fields FasterXML/jackson-databind#3948) After upgrading jackson-databind 2.13+, properties were being exposed after serialization that was set to @JsonIngore and shouldn't be.