Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed jackson transient serialization bug and handled HTTP status 204 in HTTPResponseWrapper #310

Merged
merged 9 commits into from
Jul 17, 2023

Conversation

tanmaya-panda1
Copy link
Collaborator

@tanmaya-panda1 tanmaya-panda1 commented Jul 13, 2023

Added

Changed

Fixed

  1. Handling bug from Jackson: Bug from Jackson(@JsonIgnore no longer works for transient backing fields FasterXML/jackson-databind#3948) After upgrading jackson-databind 2.13+, properties were being exposed after serialization that was set to @JsonIngore and shouldn't be.
  2. In HTTP, a response with a status code of 204 (No Content) indicates that the request was successful, but there is no content to return in the response body. Since there is no response body, there won't be an HTTP entity associated with the response and hence response.getEntity() returns IllegalArgumentException(HTTP Response entity doesn't exist) when the HTTP response code is 204 when the ingestionReportMethod is set to TABLE. As a fix handled HTTP status code 204 empty response handling in the existing HTTPResponseWrapper of azure-kusto-sdk.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023

Test Results

269 tests  +1   264 ✔️ +1   3m 16s ⏱️ - 1m 9s
  22 suites ±0       5 💤 ±0 
  22 files   ±0       0 ±0 

Results for commit d696eb6. ± Comparison against base commit 42d34fd.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #310 (3a433a2) into master (42d34fd) will decrease coverage by 0.06%.
The diff coverage is 25.00%.

❗ Current head 3a433a2 differs from pull request most recent head d696eb6. Consider uploading reports for the commit d696eb6 to get more accurate results

@@             Coverage Diff              @@
##             master     #310      +/-   ##
============================================
- Coverage     56.24%   56.19%   -0.06%     
  Complexity      699      699              
============================================
  Files           103      103              
  Lines          3737     3739       +2     
  Branches        386      387       +1     
============================================
- Hits           2102     2101       -1     
- Misses         1464     1467       +3     
  Partials        171      171              
Impacted Files Coverage Δ
...oft/azure/kusto/data/auth/HttpResponseWrapper.java 0.00% <0.00%> (ø)
...ain/java/com/microsoft/azure/kusto/data/Utils.java 33.83% <100.00%> (ø)

... and 1 file with indirect coverage changes

@tanmaya-panda1 tanmaya-panda1 changed the title fixed jackson transient serialization bug fixed jackson transient serialization bug and handled HTTP status 204 in HTTPResponseWrapper Jul 14, 2023
Copy link
Contributor

@AsafMah AsafMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

…hub.com:Azure/azure-kusto-java into feature/fix-jackson-transient-serialization-bug
@AsafMah AsafMah merged commit 79cc872 into master Jul 17, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants