Browser react sample project #269
Conversation
| <div | ||
| {...getRootProps()} | ||
| style={{ | ||
| borderStyle: "solid", |
There was a problem hiding this comment.
should move all inline css into scss modules files
How to start:
https://stackoverflow.com/a/67353154
install and write scss files with naming convention .module.scss
then import it in the jsx file like so: import styles from './file.module.scss';
then add className to the div as such: <div className={styles.nameOfIt} ...>
There was a problem hiding this comment.
I think ill leave this as is - because its just a sample and this was easier for me
| @@ -0,0 +1,61 @@ | |||
| import { Button } from "@fluentui/react-components"; | |||
| import { Client } from "azure-kusto-data"; | |||
| import React from "react"; | |||
There was a problem hiding this comment.
install eslint and prettier and others, It will help with fixing by conventions. like React comes first and the rest better be orders alphabetically
Here is a blog about those:
https://medium.com/dooboolab/using-eslint-prettier-and-sort-imports-vscode-extensions-for-formatting-open-source-project-16edf317129d
There was a problem hiding this comment.
We already use eslint
There was a problem hiding this comment.
We already have eslint - dont think its critical that it will align with what you have on webux
| label="Mapping value" | ||
| onChange={(_, data: string) => { | ||
| state.configData.mappingValue = data; | ||
| setState({ ...state }); |
There was a problem hiding this comment.
| setState({ ...state }); | |
| setState(state); |
| error?: string; | ||
| disabled?: boolean; | ||
| } | ||
| export const RowAligned: React.FunctionComponent<{ children: React.ReactNode }> = (props) => { |
There was a problem hiding this comment.
| export const RowAligned: React.FunctionComponent<{ children: React.ReactNode }> = (props) => { | |
| export const RowAligned: React.FC = ({children}) => { |
There was a problem hiding this comment.
it doesnt like children without type
Codecov Report
@@ Coverage Diff @@
## master #269 +/- ##
==========================================
- Coverage 82.72% 82.68% -0.05%
==========================================
Files 38 38
Lines 1881 1888 +7
Branches 425 426 +1
==========================================
+ Hits 1556 1561 +5
- Misses 317 319 +2
Partials 8 8
|
Added
Fixed