Compute: update to package-2019-12 and support simulate eviction #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xseeseesee
requested review from
ChenTanyi,
weidongxu-microsoft and
yungezz
as code owners
ChenTanyi
reviewed
Jun 1, 2020
.../java/com/microsoft/azure/management/compute/implementation/ProximityPlacementGroupImpl.java
Show resolved
Hide resolved
weidongxu-microsoft
approved these changes
Jun 1, 2020
sandeepkv93
reviewed
Jun 3, 2020
| SdkContext.sleep(30 * 60 * 1000); | ||
|
|
||
| virtualMachine = computeManager.virtualMachines().getById(virtualMachine.id()); | ||
| Assert.assertNotNull(virtualMachine); |
There was a problem hiding this comment.
Assert if the vm state is deallocated. When it is deallocated, vm entity will still be there.
There was a problem hiding this comment.
Do we need to get such state via InstanceView?
| SdkContext.sleep(30 * 60 * 1000); | ||
|
|
||
| for (VirtualMachineScaleSetVM instance: vmInstances) { | ||
| instance.refresh(); |
There was a problem hiding this comment.
Same as Single VM. Check the vm state of each VM.
sandeepkv93
approved these changes
Jun 3, 2020
7 tasks
2 tasks
xseeseesee
added a commit
to Azure/azure-sdk-for-java
that referenced
this pull request
Jun 29, 2020
* Compute: upgrade api version * Compute: generate package-2019-12 * fix compile errors * update record sessions * sync Azure/azure-libraries-for-java#1049 * sync Azure/azure-libraries-for-java#1177 * sync Azure/azure-libraries-for-java#1199 * fix spotbugs error * sync specialized image changes and rename generalized methods * update session records * fix checkstyle * update session record
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.