Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRedisCache has no fluent methods for linkedServers/firewallRules? #303

Closed
TimLovellSmith opened this issue May 3, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@TimLovellSmith
Copy link
Member

Based on feedback from someone else I was just reviewing the Microsoft.Azure.Redis.Management.Fluent package, and found surprisingly that while it has support for the linkedServers/firewallRules via RedisManagementClient, there seems to be no way to get to those things from the IRedisCaches/IRedisCache interfaces.

i.e. you can do this
var x = caches.GetById(id).AsPremium().ListPatchSchedules();

but not these
var x = caches.GetById(id).AsPremium().ListLinkedServers();
var x = caches.GetById(id).ListFirewallRules(); // note, firewall rules no longer requires premium SKU

@hovsepm hovsepm self-assigned this May 3, 2018
@hovsepm hovsepm added this to the v1.11 milestone May 17, 2018
@hovsepm hovsepm modified the milestones: v1.11, v1.12 May 31, 2018
@hovsepm
Copy link
Contributor

hovsepm commented May 31, 2018

@TimLovellSmith all 3 issues for Redis Fluent planned for v1.11 are moved to v1.12. LMK if this blocks any of your customers.

@hovsepm hovsepm modified the milestones: v1.12, v1.13 Jun 22, 2018
hovsepm added a commit to Azure/azure-libraries-for-java that referenced this issue Jun 29, 2018
* Regenerated Redis with latest fixes.

* fix for Azure/azure-libraries-for-net#305

* Fix for Azure/azure-libraries-for-net#304

* fix for Azure/azure-libraries-for-net#303

* Fixed build break

* commit of the current dev state

* Added comments.

* Fixed stylecheck errors.

* fix of the fix

* Fixed the fix of the fix

* Fix the build break.

* Fix for PatchSchedule failures

* fixed style check breaks

* Fixed LinkedServers.

* Fixed build breaks.

* Re-recorded redis Azure test

* re-recorded Redis sample

* Fixed Beta since text.
@hovsepm
Copy link
Contributor

hovsepm commented Jul 16, 2018

Release 1.13 is out. Please upgrade your references.

@hovsepm hovsepm closed this as completed Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants