Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage SQL Information Protection Policy #11558

Merged
merged 11 commits into from
Apr 22, 2020
Merged

Manage SQL Information Protection Policy #11558

merged 11 commits into from
Apr 22, 2020

Conversation

bashahee
Copy link
Contributor

@bashahee bashahee commented Apr 13, 2020

Description

Support management of SQL Information Protection Policy by adding two new Cmdlets: Set-AzSqlInformationProtectionPolicy and Get-AzSqlInformationProtectionPolicy.

The design was reviewed and accepted in https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/530.

Tests were added, and some existing tests records were updated.

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@bashahee
Copy link
Contributor Author

@cormacpayne @MiYanni @wyunchi-ms
Hi all,
Is there any chance for this PR to be merged today, so it gets shipped with next upcoming release?

@cormacpayne
Copy link
Member

@bashahee Hey Basel, @MiYanni and I are no longer a part of the Azure PowerShell team -- it looks like @msJinLei may be the on-call person for Azure PowerShell this release, so they should be able to help at their earliest convenience.

@bashahee bashahee marked this pull request as draft April 13, 2020 20:13
@bashahee
Copy link
Contributor Author

@msJinLei Hi, please wait with your review, as I found a small bug in last minute.

@wyunchi-ms
Copy link
Contributor

Hi @bashahee this PR can be merged today only if it can pass the CI.

@wyunchi-ms wyunchi-ms self-assigned this Apr 14, 2020
@wyunchi-ms
Copy link
Contributor

Hi @bashahee , is this PR ready for reviewing?

@bashahee
Copy link
Contributor Author

@wyunchi-ms The PR is ready to be reviewed. However, it is not ready to be merged, I need to consume latest SDK clients package, after this PR is merged Azure/azure-rest-api-specs#9053.

@bashahee bashahee marked this pull request as ready for review April 22, 2020 06:12
@bashahee
Copy link
Contributor Author

@wyunchi-ms Hi, the PR is ready to be merged now, thank you for the design and the PR review!

@wyunchi-ms
Copy link
Contributor

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@wyunchi-ms wyunchi-ms merged commit e307a2a into Azure:master Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants