Add 2024-06-01-preview for redis enterprise #25460

revanthballa1188 · 2024-07-05T08:04:59Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- For autorest-based development mode, include the changelog in the PR description.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2024-07-05T08:05:01Z

️✔️Az.Accounts

️✔️Build

️✔️PowerShell Core - Windows

⚠️Az.RedisEnterpriseCache

️✔️Build

️✔️PowerShell Core - Windows

️✔️Breaking Change Check

️✔️PowerShell Core - Windows

⚠️Signature Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ Get-AzRedisEnterpriseCache Get-AzRedisEnterpriseCache Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzRedisEnterpriseCache Get-AzRedisEnterpriseCache changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzRedisEnterpriseCacheDatabase Get-AzRedisEnterpriseCacheDatabase Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzRedisEnterpriseCacheDatabase Get-AzRedisEnterpriseCacheDatabase changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️ Get-AzRedisEnterpriseCacheOperationStatus Get-AzRedisEnterpriseCacheOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue

⚠️ Get-AzRedisEnterpriseCacheOperationStatus Get-AzRedisEnterpriseCacheOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.

⚠️Help Example Check

⚠️PowerShell Core - Windows

Type Cmdlet Example Line RuleName Description Extent Remediation

⚠️ New-AzRedisEnterpriseCache 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -Module '{name:RedisBloom, args:'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type. -Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.IModule. Now the type is string.(Static).

⚠️ New-AzRedisEnterpriseCache 4 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCache -LinkedDatabase '{id:'/subscriptions/6b9ac7d2-7f6d-4de4-962c-43fda44bc3f2/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.ILinkedDatabase. Now the type is string.(Static).

⚠️ New-AzRedisEnterpriseCacheDatabase 1 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -Module '{name:RedisBloom, args:'ERROR_RATE 0.00 INITIAL_SIZE 400'}','{name:RedisTimeSeries, args:'RETENTION_POLICY 20'}','{name:RediSearch}' is not an expected parameter value type. -Module Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.IModule. Now the type is string.(Static).

⚠️ New-AzRedisEnterpriseCacheDatabase 2 1 Mismatched_Parameter_Value_Type New-AzRedisEnterpriseCacheDatabase -LinkedDatabase '{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache1/databases/default'}','{id:'/subscriptions/sub1/resourceGroups/MyGroup/providers/Microsoft.Cache/redisEnterprise/MyCache2/databases/default'}' is not an expected parameter value type. -LinkedDatabase Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.RedisEnterpriseCache.Models.Api20240601Preview.ILinkedDatabase. Now the type is string.(Static).

️✔️Help File Existence Check

️✔️PowerShell Core - Windows

⚠️File Change Check

⚠️PowerShell Core - Windows

Type Cmdlet Description Remediation

⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.RedisEnterpriseCache. Add a changelog record under Upcoming Release section with past tense.

️✔️UX Metadata Check

️✔️PowerShell Core - Windows

⚠️Test

⚠️ - Linux

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 47.06 % Test coverage for the module cannot be lower than 50%.

⚠️ - MacOS

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 47.06% Test coverage for the module cannot be lower than 50%.

⚠️PowerShell Core - Windows

Type Title Current Coverage Description

⚠️ Test Coverage Less Than 50% 47.06% Test coverage for the module cannot be lower than 50%.

VeryEarly · 2024-07-23T01:53:16Z

/azp run

azure-pipelines · 2024-07-23T01:53:33Z

Azure Pipelines successfully started running 3 pipeline(s).

VeryEarly · 2024-07-23T02:44:13Z

please record tests after API upgrade

revanthballa1188 · 2024-08-06T06:59:21Z

Test recordings have been added

dolauli · 2024-08-07T02:17:25Z

@revanthballa1188 Please fix issues in examples that lead to the CI failure.

…into generation

revanthballa1188 · 2024-08-29T07:15:04Z

/azp run

azure-pipelines · 2024-08-29T07:15:11Z

Commenter does not have sufficient privileges for PR 25460 in repo Azure/azure-powershell

dolauli · 2024-08-29T09:03:09Z

/azp run

azure-pipelines · 2024-08-29T09:03:25Z

Azure Pipelines successfully started running 3 pipeline(s).

msJinLei · 2024-08-29T10:26:20Z

...eCache.Autorest/examples/Invoke-AzRedisEnterpriseCacheForceDatabaseLinkToReplicationGroup.md

@@ -0,0 +1,22 @@
+### Example 1: {{ Add title here }}


Please finish the examples and regenerated the module

@revanthballa1188 You should add the example here and the files of docs are all generated.

Got it, Updated now!

msJinLei · 2024-08-29T10:26:27Z

...edisEnterpriseCache.Autorest/examples/Update-AzRedisEnterpriseCacheDatabaseDbRedisVersion.md

@@ -0,0 +1,22 @@
+### Example 1: {{ Add title here }}


Please finish the examples and regenerated the module

You should add the example here and the files of docs are all generated.

Got it! updated now!

github-actions · 2024-08-29T10:27:09Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

msJinLei · 2024-09-04T09:46:59Z

...rpriseCache/RedisEnterpriseCache.Autorest/docs/Invoke-AzRedisEnterpriseCacheDatabaseFlush.md

@@ -14,16 +14,16 @@ Flushes all the keys in this database and also from its linked databases.

 ### FlushExpanded (Default)
 ```
-Invoke-AzRedisEnterpriseCacheDatabaseFlush -ClusterName <String> -ResourceGroupName <String> [-Name <String>]


-Name is removed

msJinLei · 2024-09-04T09:49:07Z

...Cache/RedisEnterpriseCache.Autorest/docs/Invoke-AzRedisEnterpriseCacheForceDatabaseUnlink.md

@@ -83,23 +83,9 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```

-### -DatabaseName


Remove DatabaseName

msJinLei

I find several breaking changes in the PR including removing existing parameters and the change of namespaces. But why static analysis passes? We need check again. The module is a GA module

msJinLei · 2024-09-05T18:46:33Z

@revanthballa1188 Please provide the change log for this PR

Add 2024-06-01-preview for redis enterprise

19ee35e

VeryEarly and others added 2 commits July 5, 2024 17:15

Update New-AzRedisEnterpriseCache.ps1

c3500b9

update files aftre building modules

ba4c2e6

VeryEarly self-assigned this Jul 7, 2024

Add test recordings

4b2f446

VeryEarly assigned dolauli and unassigned VeryEarly Aug 6, 2024

Merge branch 'generation' of https://github.com/Azure/azure-powershell …

9d88d75

…into generation

dolauli removed their assignment Aug 29, 2024

msJinLei requested changes Aug 29, 2024

View reviewed changes

msJinLei assigned revanthballa1188 Aug 29, 2024

msJinLei added the needs-revision label Aug 29, 2024

revanthballa1188 added 3 commits September 4, 2024 11:37

Update examples of force unlink and upgrade db

ea721fe

fix SKU naming

e59e0e6

fix examples

581081d

msJinLei reviewed Sep 4, 2024

View reviewed changes

msJinLei requested changes Sep 5, 2024

View reviewed changes

msJinLei self-assigned this Sep 5, 2024

msJinLei unassigned revanthballa1188 Sep 5, 2024

msJinLei approved these changes Sep 5, 2024

View reviewed changes

msJinLei merged commit a5ac1e5 into Azure:generation Sep 5, 2024
8 checks passed

azure-pipelines bot mentioned this pull request Sep 15, 2024

Migrate RedisEnterpriseCache from generation to main #26103

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 2024-06-01-preview for redis enterprise #25460

Add 2024-06-01-preview for redis enterprise #25460

revanthballa1188 commented Jul 5, 2024 •

edited by msJinLei

Loading

azure-client-tools-bot-prd bot commented Jul 5, 2024 •

edited

Loading

VeryEarly commented Jul 23, 2024

azure-pipelines bot commented Jul 23, 2024

VeryEarly commented Jul 23, 2024

revanthballa1188 commented Aug 6, 2024

dolauli commented Aug 7, 2024

revanthballa1188 commented Aug 29, 2024

azure-pipelines bot commented Aug 29, 2024

dolauli commented Aug 29, 2024

azure-pipelines bot commented Aug 29, 2024

msJinLei Aug 29, 2024

revanthballa1188 Sep 4, 2024

msJinLei Sep 4, 2024

revanthballa1188 Sep 4, 2024

msJinLei Aug 29, 2024

revanthballa1188 Sep 4, 2024

msJinLei Sep 4, 2024

revanthballa1188 Sep 4, 2024

github-actions bot commented Aug 29, 2024

msJinLei Sep 4, 2024

msJinLei Sep 4, 2024

msJinLei left a comment •

edited

Loading

msJinLei commented Sep 5, 2024

Add 2024-06-01-preview for redis enterprise #25460

Add 2024-06-01-preview for redis enterprise #25460

Conversation

revanthballa1188 commented Jul 5, 2024 • edited by msJinLei Loading

Description

Mandatory Checklist

azure-client-tools-bot-prd bot commented Jul 5, 2024 • edited Loading

VeryEarly commented Jul 23, 2024

azure-pipelines bot commented Jul 23, 2024

VeryEarly commented Jul 23, 2024

revanthballa1188 commented Aug 6, 2024

dolauli commented Aug 7, 2024

revanthballa1188 commented Aug 29, 2024

azure-pipelines bot commented Aug 29, 2024

dolauli commented Aug 29, 2024

azure-pipelines bot commented Aug 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

msJinLei left a comment • edited Loading

Choose a reason for hiding this comment

msJinLei commented Sep 5, 2024

revanthballa1188 commented Jul 5, 2024 •

edited by msJinLei

Loading

azure-client-tools-bot-prd bot commented Jul 5, 2024 •

edited

Loading

msJinLei left a comment •

edited

Loading