Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerShell Release Network 2024 03 01 #26080

Merged
merged 11 commits into from
Sep 20, 2024
Merged

Conversation

kamboj-prjwl
Copy link
Member

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

YanaXu and others added 9 commits July 26, 2024 17:25
* PS Changes for User Managed Identity

* update changeLog.md

* update changeLog.md

* Update ChangeLog.md

* updating New-AzNetworkWatcherFlowLog.md file

---------

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
…wlogs (#25709)

* Powershell code changes to support new field in flowlogs

* adding unit tests

* Help generation

* Generated flowlogs related files

* Revert "Generated flowlogs related files"

This reverts commit 4e7c8c0.

* add changeLog.md

* Reapply "Generated flowlogs related files"

This reverts commit 0b7db60.

* Adding session records

* Revert "Reapply "Generated flowlogs related files""

This reverts commit b17598d.

* Modified  TestVnetFlowLogWithEmptyFilteringCondition and TestVnetFlowLogWithFiltering

* Help files

* Model generated flowlogs files

* Commit added to ReadMe file against 2024-03-01

* Checking in all the generated files

---------

Co-authored-by: Mansi Verma <manverm@microsoft.com>
Removed noHealthyBackendsBehavior directive.
…ule Override (#25705)

* sensitivity add

* add back deleted rule

* add back deleted rule

* removed bracket

* merge conf

* edit comment and add nuget

* retry test

* fix test

* edit sdk

* edit test
* fixing packet capture call to be async

* fixing the test to return success

* replaced the hard coded sasurl with sasurl generated on the fly

* Adding session record for the fixed test

* adding change summary to changelog.md

* skipping test in cloud runner due to issues accessing deployed storage account

* removing storage account actions, replacing the sessions recording and replacing the sasurl with a dummySAS as per recommendation

* mask sas url in record json

---------

Co-authored-by: Yabo Hu <yabhu@microsoft.com>
* Init

* Adding help content

* Update test run

* Null check

* Update ChangeLog.md

* Update help

* Update test result

* Minor string changes

* Update ChangeLog.md

* Updating BSL label

* Update help

* Update Remove-AzBastionShareableLink.md

* Update ChangeLog.md

---------

Co-authored-by: Abhishek Shah <shabhis@microsoft.com>
Co-authored-by: Jin Lei <54836179+msJinLei@users.noreply.github.com>
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@kamboj-prjwl
Copy link
Member Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26080 in repo Azure/azure-powershell

@msJinLei
Copy link
Contributor

Please resolve the conflicts

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@msJinLei
Copy link
Contributor

@kamboj-prjwl Is the PR going to wait for the following PRs?
#26091
#25810

@msJinLei msJinLei added the needs-author-feedback More information is needed from author to address the issue. label Sep 15, 2024
* Add destination IP address as parameter for PLS

* Make Loadbalancer non required
@kamboj-prjwl
Copy link
Member Author

@kamboj-prjwl Is the PR going to wait for the following PRs? #26091 #25810

@msJinLei Yes , we need to wait for above branches.

@microsoft-github-policy-service microsoft-github-policy-service bot added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. labels Sep 16, 2024
@msJinLei
Copy link
Contributor

@kamboj-prjwl Is the PR going to wait for the following PRs? #26091 #25810

@msJinLei Yes , we need to wait for above branches.

@kamboj-prjwl
#25810 can target to main when the network release branch is merged. I propose you to get your PR done as soon as possible as the code completion date is drawing near.

@msJinLei msJinLei added the Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. label Sep 19, 2024
Copy link

‼️ Do NOT use squash to merge this pull request. All the commits must be merged to the target branch.
‼️ Enable "Allow merge commits" in the pull request settings. Select "Merge Commits" to merge the PR. Then go back to settings and disable the option.

@msJinLei msJinLei merged commit a3656bc into main Sep 20, 2024
2 of 3 checks passed
@VeryEarly VeryEarly deleted the release-network-2024-03-01 branch September 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Squash 🚫 To prevent conflicts, this PR should not be squash merged. needs-revision needs-team-attention This issue needs attention from Azure service team or SDK team
Projects
None yet
Development

Successfully merging this pull request may close these issues.