Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview Release ConnectedMachine 2024-05-20 #26138

Merged
merged 16 commits into from
Sep 24, 2024

Conversation

yaotongms
Copy link
Member

@yaotongms yaotongms commented Sep 20, 2024

Description

This release is targeting version 2024-05-20-preview of ConnectedMachine.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 20, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.ConnectedMachine
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedExtensionMetadata Get-AzConnectedExtensionMetadata changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedLicense Get-AzConnectedLicense Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedLicense Get-AzConnectedLicense changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachine Get-AzConnectedMachine changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineExtension Get-AzConnectedMachineExtension changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedMachineRunCommand Get-AzConnectedMachineRunCommand changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration Get-AzConnectedNetworkSecurityPerimeterConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedNetworkSecurityPerimeterConfiguration Get-AzConnectedNetworkSecurityPerimeterConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzConnectedPrivateLinkScope Get-AzConnectedPrivateLinkScope changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzConnectedLicenseDetail New-AzConnectedLicenseDetail Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ New-AzConnectedLicenseDetail New-AzConnectedLicenseDetail changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ New-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable New-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Remove-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Remove-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ResourceGroupName $resourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $resourceGroupName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -ScopeName $scopeName is a null-valued parameter value. -ScopeName Assign value for $scopeName.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Tag $tags is a null-valued parameter value. -Tag Assign value for $tags.
⚠️ Set-AzConnectedPrivateLinkScope 1 1 Unassigned_Variable Set-AzConnectedPrivateLinkScope -Location $location is a null-valued parameter value. -Location Assign value for $location.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedExtension 1 2 Unassigned_Variable Update-AzConnectedExtension -MachineName $machineName is a null-valued parameter value. -MachineName Assign value for $machineName.
⚠️ Update-AzConnectedMachine 1 1 Unassigned_Variable Update-AzConnectedMachine -Name $env.MachineName is a null-valued parameter value. -Name Assign value for $env.MachineName.
⚠️ Update-AzConnectedMachine 1 1 Unassigned_Variable Update-AzConnectedMachine -ResourceGroupName $env.ResourceGroupName is a null-valued parameter value. -ResourceGroupName Assign value for $env.ResourceGroupName.
⚠️ Update-AzConnectedMachine 1 1 Unassigned_Variable Update-AzConnectedMachine -PrivateLinkScopeResourceId $env.PrivateLinkScopeUri is a null-valued parameter value. -PrivateLinkScopeResourceId Assign value for $env.PrivateLinkScopeUri.
⚠️ Update-AzConnectedMachineExtension 4 4 Mismatched_Parameter_Value_Type Update-AzConnectedMachineExtension -ExtensionParameter $extToUpdate is not an expected parameter value type. -ExtensionParameter Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtensionUpdate. Now the type is Microsoft.Azure.PowerShell.Cmdlets.ConnectedMachine.Models.IMachineExtension.(Command).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.ConnectedMachine. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@@ -67,31 +63,19 @@ The operation to update a hybrid machine.

## EXAMPLES

### Example 1: Update a machine using parameters
### -------------------------- EXAMPLE 1 --------------------------
```powershell
Update-AzConnectedMachine -Name surface -ResourceGroupName rg -PrivateLinkScopeResourceId privateLinkScopeId -WindowsConfigurationPatchSettingsAssessmentMode AutomaticByOS -Tag @{"key"="value"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cmdlet help should be generated according to example

@msJinLei msJinLei merged commit b188a5e into Azure:generation Sep 24, 2024
9 checks passed
jaskisin pushed a commit to jaskisin/azure-powershell that referenced this pull request Oct 8, 2024
* generate code

* add license profile and network configuration cmdlet

* remove license profile and network configuration

* remove NSP PATCH test

* test

* test

* custom cmdlet

* update

* test

* test

* test

* Fix static analysis error

* Generate using autorest.powershell 4.0.712

* Generate help using autorest.powershell 4.0.715

---------

Co-authored-by: Lei Jin <leijin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants