Merge branch 'master' into add-terraform-config-to-customproviders-co…

…nfig

# Conflicts:
#	specification/customproviders/resource-manager/readme.trenton.md

.azure-pipelines-preproduction/package.json

@@ -10,8 +10,8 @@
   "description": "Tests for Azure REST API Specifications",
   "license": "MIT",
   "devDependencies": {
-    "@azure/avocado": "^0.6.2",
-    "@azure/rest-api-specs-scripts": "^0.6.8",
+    "@azure/avocado": "^0.6.3",
+    "@azure/rest-api-specs-scripts": "^0.7.2",
     "@ts-common/commonmark-to-markdown": "^1.2.0",
     "@ts-common/fs": "0.2.0",
     "@ts-common/iterator": "^0.3.6",

.github/assignment.yml

@@ -14,7 +14,6 @@
       - "specification/network/**"
     reviewers:
       - lirenhe
-      - zikalino
       - MyronFanQiu
 
 - rule:
@@ -83,6 +82,12 @@
       - fengzhou-msft 
       - yungezz
 
+- rule:
+    paths:
+      - "specification/mixedreality/**"
+    reviewers:
+      - leni-msft
+
 - rule:
     paths:
       - "specification/portal/**"
@@ -121,7 +126,6 @@
     reviewers:
       - yungezz
       - zikalino
-      - yaohaizh
       - erich-wang
       - NullMDR
       - raych1

CODEOWNERS

@@ -34,7 +34,7 @@
 /specification/insights/ @gucalder
 /specification/intune/ @vrmurthy01
 /specification/iothub/ @rkmanda
-/specification/keyvault/ @schaabs @heaths
+/specification/keyvault/ @heaths @randallilama @jlichwa
 /specification/logic/ @pankajsn @tonytang-microsoft-com
 /specification/machinelearning/ @nonstatic2014
 /specification/machinelearningcompute/ @shutchings

cSpell.json

@@ -188,6 +188,12 @@
                 "Exprired"
             ]
         },
+        {
+            "filename": "**/specification/synapse/resource-manager/Microsoft.Synapse/preview/2019-06-01-preview/integrationRuntime.json",
+            "words": [
+                "Exprired"
+            ]
+        },
         {
             "filename": "**/specification/datamigration/resource-manager/Microsoft.DataMigration/preview/2018-07-15-preview/definitions/TasksCommon.json",
             "words": [

custom-words.txt

@@ -412,6 +412,7 @@ deletedsecrets
 deletedstorage
 deletefailed
 deleteissuers
+deleteprivateendpointconnection
 deletesas
 demorun
 denylist
@@ -484,6 +485,7 @@ endswith
 endtime
 Enein
 engagementfabric
+endzone
 enquoted
 entitydocument
 entitysearch
@@ -586,6 +588,8 @@ GETFILESTATUS
 getissuers
 getjob
 getkey
+getprivateendpointconnection
+getprivatelinkresources
 getsas
 getskus
 getssotoken
@@ -649,6 +653,7 @@ hybridconnection
 hybriddata
 hybriddatamanager
 Hyperdrive
+Hypernet
 Hyperscale
 hyperv
 Iaas
@@ -695,13 +700,15 @@ iothub
 iothubprovisioningservices
 iotspaces
 iotspacesservice
+ipam
 ipconfig
 ipconfiguration
 ipconfigurations
 ipfilterrules
 Ipsec
 ipssl
 ipgroups
+IPAM
 iscloneable
 Iscsi
 iscsiservers
@@ -796,6 +803,8 @@ listissuers
 listjobs
 listkeys
 listprebuilts
+listprivateendpointconnections
+listprivatelinkresources
 listsas
 listsecrets
 LISTSTATUS
@@ -1153,6 +1162,7 @@ RAGRS
 RAGZRS
 randint
 Rankable
+ratelimit
 ravbhatnagar
 rawxml
 rbac
@@ -1588,6 +1598,7 @@ unvalidated
 unwrapkey
 updatecertificate
 updatehostname
+updateprivateendpointconnection
 updateproperties
 upgradeos
 uploadbatchservicelogs

documentation/ci-fix.md

@@ -13,13 +13,81 @@ If your problem is some existing error name that is not a word and need to supre
 Please run the following command (from an administrator Node.js command prompt if running on Windows):
 
 ```
-npm install; npm run prettier-fix
+npm install
+npm run prettier-fix
 ```
 
 Or if you want to fix specified service:
 
 ```
-npm install; npm run prettier -- --write "specification/<service>/**/*.json"
+npm install
+npm run prettier -- --write "specification/<service>/**/*.json"
 ```
 
 Then please commit and push changes made by prettier.
+
+## Model Validation
+
+Run Model Validation locally:
+```
+npm install -g oav
+oav validate-example <swagger-spec-path>
+```
+Please see [readme](https://github.com/Azure/oav/blob/master/README.md) for how to install or run tool in details.
+Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/static-validation/static/errors/default)
+Refer to [Semantic and Model Violations Reference](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md) for detailed description of validations and how-to-fix guidance.
+
+## Semantic Validation
+Run Semantic Validation locally:
+```
+npm install -g oav
+oav validate-spec <swagger-spec-path>
+```
+Please see [readme](https://github.com/Azure/oav/blob/master/README.md) for how to install or run tool in details.
+Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/static-validation/static/errors/default)
+Refer to [Semantic and Model Violations Reference](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/Semantic-and-Model-Violations-Reference.md) for detailed description of validations and how-to-fix guidance.
+
+## Breaking Change Check
+
+run oad locally (the breaking change is reported by oad tool):
+```
+npm install -g oad
+oad compare <old-spec-path> <new-spec-path> 
+```
+Please see [readme](https://github.com/Azure/openapi-diff/blob/master/README.md) for how to install or run tool in details.
+Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/diff).
+Refer to [Oad Docs](https://github.com/Azure/openapi-diff/tree/master/docs) for detailed description of all oad rules and how-to-fix guidance.
+
+## Linter Validation
+
+Run linter locally:
+```
+npm install -g autorest
+autorest --validation --azure-validator --input-file=<path-to-spec>
+or
+autorest --validation --azure-validator <path-to-readme>
+
+```
+Please see [readme](https://github.com/Azure/azure-openapi-validator/blob/master/README.md) for how to install or run tool in details.
+Or you can run it in [OpenAPI Hub](https://portal.azure-devex-tools.com/tools/linter).
+Refer to [openapi-authoring-automated-guidelines](https://github.com/Azure/azure-rest-api-specs/blob/master/documentation/openapi-authoring-automated-guidelines.md) for detailed description of all lint rules and how-to-fix guidance.
+
+## Avocado
+
+Run avocado locally:
+
+```
+npm install -g @azure/avocado
+
+avocado
+```
+
+When type avocado in command line, avocado will validate in the current directory.
+
+Note: When running in Swagger PR pipeline, Avocado only report errors with file updates in the PR, but ignore the errors existing in base. However when running Avocado against local directory, it reports all errors existing in the files.
+
+- Run all specs: Clone the repo `azure/azure-rest-api-specs` and run "avocado" in folder `azure/azure-rest-api-specs`.
+- Run single service specs: create a folder `specification`. and move your service specs folder in `specification`. run "avocado"
+
+Refer to [Avocado Readme](https://github.com/Azure/avocado/blob/master/README.md) for detailed description of validations and how-to-fix guidance.
+