Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Client description to include Gen2 #10178

Merged

Conversation

Sandip-Raiyani
Copy link
Contributor

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

sandshadow and others added 30 commits January 9, 2018 17:03
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
…Prop

Added dataStringComparisonBehavior parameter to reference data put/update spec
…onKeyProperty

Adding partitionKeyProperty to EnvironmentCreate and EnvironmentGet request.
…lingAsString

changing modelAsString for partitionKeyPRoperties
Introduce longterm environment to TSI resource hierarchy
@AutorestCI
Copy link

You don't have permission to trigger SDK Automation.
Please add yourself to Azure group from opensource portal if you are MSFT employee,
or please ask reviewer to add comment *** /openapibot sdkautomation ***.
Please ask tih@microsoft.com (or NullMDR in github) for additional help.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 16, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@Sandip-Raiyani
Copy link
Contributor Author

@tjprescott Thanks for the quick approval. Can you merge this PR?

@tjprescott
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@tjprescott tjprescott merged commit 85ac404 into Azure:master Jul 27, 2020
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 27, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

iscai-msft added a commit to iscai-msft/azure-rest-api-specs that referenced this pull request Oct 5, 2020
…into fix_kv_python_readme

* 'master' of https://github.com/Azure/azure-rest-api-specs: (154 commits)
  Key Vault 7.1-preview to stable (GA) (Azure#10239)
  Fix data plane cosmosdb (Azure#10277)
  Fix example request for expanding policyEvaluationDetails (Azure#10203)
  Databricks Swagger Changes for Double Encryption (Azure#9941)
  add column delimiter for SAP Table/open hub (Azure#10269)
  add doc for typescript md (Azure#10187)
  Fix sfrp 2020-01-01-preview (Azure#10268)
  [Datafactory]Add cloudType and snapshot to ADF public swagger (Azure#10235)
  Migrate TaskRun to ProxyResource. (Azure#9953)
  [Datashare]Add sorting query parameters (Azure#10209)
  [Hub Generated] Review request for Microsoft.Insights to add version preview/2018-06-17-preview (Azure#10173)
  Update dataController onPremise property (Azure#10263)
  Changed the Client description to include Gen2 (Azure#10178)
  Managed Clusters Generate SDK (Azure#10247)
  Dev monitor microsoft.insights 2020 05 01 preview (Azure#10101)
  Add Location property to ExportPipeline and ImportPipeline (Azure#10177)
  Add enableAutomaticUpgrade property to VMExtensions for VMs and VMSS (Azure#10134)
  Add a new api and add 2020-02-02-preview versions (Azure#9710)
  Adding AML Workspace ID Property (Azure#10073)
  Add missing nullable attributes (Azure#10245)
  ...
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
* Fix or suppress spec violations
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.

* Try removing 2nd top-level heading, which _may_ have been causing a linter warning.

* Fix extra indention which prevented linter from running.

* Added dataStringComparisonBehavior parameter to reference data put/update spec.

* Fixed grammar.

* adding partitionkeyProperty to environmentInfo

* changing property name

* changing modelAsString

* Initial checkin of spec. Unchanged from GA release other than version.

* Remove .orig files

* Fix validation error by removing IoTHub ES from List ES example response

* Add extra example that was missing from preview spec.

* Add long-term environment to resource hierarchy, and update examples.

* Switch to model-as-string for enums. Restore EnvironmentResource's inheritance from TrackedResource.

* Upsate sku description

* Add new TSI preview api-version to readme.md.

* Add suppressions for false-positive linter failures.

* Test suppression failures

* Adding preview package tag to several other places in readme.md

* Add preview package to the readme.go.md file

* Remove invalid required property from EnvironmentCreateOrUpdateParameters

* Initial version of data plane swagger spec for PAYG (Preview) SKU.

* Added missing Readme.md

* Fixed name of readme

* Fixed path to swagger json

* Attempt to fix readme

* Apply suggestions from code review

Co-Authored-By: dmdenmsft <dmden@microsoft.com>

* Update timeseriesinsights.json

* Update timeseriesinsights.json

* Added link to oav issue

* Changed the Client description to include Gen2

* updated description

Co-authored-by: Eric Dettinger <edett@microsoft.com>
Co-authored-by: Karthik Subramanian <karthik.s.sundaram@gmail.com>
Co-authored-by: Ravi Kumar Suresh Babu <kurav@microsoft.com>
Co-authored-by: ravikumarsureshbabu <dropmailtoravi@gmail.com>
Co-authored-by: Dmitry Denisov <dmden@microsoft.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Karthik Subramanian <karsubr@microsoft.com>
Co-authored-by: Ric Serradas <riserrad@microsoft.com>
Co-authored-by: Richard Wydrowski <wydrowski@hotmail.com>
Co-authored-by: Sandip Raiyani <saraiyan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.