Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small updates #10254

Merged
merged 1 commit into from
Jul 28, 2020
Merged

small updates #10254

merged 1 commit into from
Jul 28, 2020

Conversation

viv-liu
Copy link
Contributor

@viv-liu viv-liu commented Jul 24, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 24, 2020

[Staging] Swagger Validation Report

BreakingChange: 5 Errors, 0 Warnings [Detail] [Expand]
Rule Message
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'description' renamed or removed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'description' renamed or removed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'description' renamed or removed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'description' renamed or removed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'description' renamed or removed?
New: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
Old: Microsoft.IoTCentral/preview/2019-10-28-preview/iotcentral.json#L293:7
LintDiff: 2 Errors, 0 Warnings [Detail] [Expand]
Rule Message
An error occurred while executing JSON.parse() on the linter output for specification/iotcentral/data-plane/readme.md: "role":"Lint Diff",
"new":"https://github.com/Azure/azure-rest-api-specs/blob/c8580b72b0576e9ae0a189d59fcec7fdee71377f/specification/iotcentral/data-plane/readme.md",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/iotcentral/data-plane/readme.md"
An error occurred while executing JSON.parse() on the linter output for specification/iotcentral/data-plane/readme.md: "role":"Lint Diff",
"new":"https://github.com/Azure/azure-rest-api-specs/blob/c8580b72b0576e9ae0a189d59fcec7fdee71377f/specification/iotcentral/data-plane/readme.md",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/master/specification/iotcentral/data-plane/readme.md"
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-js - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-java - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-python - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-go - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-net - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

Trenton Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jul 24, 2020

azure-sdk-for-python-track2 - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@viv-liu
Copy link
Contributor Author

viv-liu commented Jul 24, 2020

@lmazuel @clecompt-msft it's complaining about the email format thing in the LintDiff again 🥇

@lmazuel lmazuel merged commit c18564b into Azure:master Jul 28, 2020
00Kai0 pushed a commit to 00Kai0/azure-rest-api-specs that referenced this pull request Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants