-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tofriedl/query packs update #10457
Tofriedl/query packs update #10457
Conversation
[Staging] Swagger Validation Report
Only 10 items are listed, please refer to log for more details.
❌ |
Rule | Message |
---|---|
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries/search' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L88:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/queryPacks' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L37:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries/{queryId}' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L148:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L112:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L73:5 |
1005 - RemovedPath |
The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries' removed or restructured? Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L37:5 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'categories' renamed or removed? New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L452:7 Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L332:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'code' renamed or removed? New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L333:7 Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L284:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'message' renamed or removed? New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L333:7 Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L284:7 |
1033 - RemovedProperty |
The new version is missing a property found in the old version. Was 'queryId' renamed or removed? New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L452:7 Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L332:7 |
️️✔️
LintDiff [Detail]
️✔️
Validation passes for LintDiff.
️️✔️
Avocado [Detail]
️✔️
Validation passes for Avocado.
Azure Pipelines successfully started running 1 pipeline(s). |
Azure CLI Extension Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-sdk-for-go - Release
|
azure-sdk-for-java - Release
|
azure-sdk-for-js - Release
|
azure-sdk-for-net - Release
|
azure-sdk-for-python - Release
- Breaking Change detected in SDK
|
azure-sdk-for-python-track2 - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
Trenton Generation - Release
No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured
|
azure-resource-manager-schemas - Release
|
Can one of the admins verify this patch? |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
i want to address 2 of the failed steps: #1 regarding Prettier check - i ran prettier for all files and prettier tool did not changed any file. Thanks, Tom. |
...hts/resource-manager/Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json
Show resolved
Hide resolved
Since there was not new api, remove ARM review requests. |
@tofriedl Could you try |
Azure Pipelines successfully started running 1 pipeline(s). |
@myronfanqiu - done. prettier was ran. |
Azure Pipelines successfully started running 1 pipeline(s). |
@tofriedl Hi. Meanwhile, there is a lint error. Could you please add corresponding api into the file? |
@myronfanqiu - Lint error is "R3023 - OperationsAPIImplementation" but Microsoft.Insights RP do have Operations API implemented. |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
Azure Pipelines successfully started running 1 pipeline(s). |
@myronfanqiu - i added Operations API. LintDiff check seems to success now. |
Since these apis have no real customers right now. It's not a real breaking change. |
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.
Please follow the link to find more details on PR review process.