Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tofriedl/query packs update #10457

Merged
merged 28 commits into from
Aug 18, 2020
Merged

Conversation

tofriedl
Copy link
Contributor

@tofriedl tofriedl commented Aug 13, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 13, 2020

[Staging] Swagger Validation Report

BreakingChange: 23 Errors, 0 Warnings [Detail] [Expand] Only 10 items are listed, please refer to log for more details.
Rule Message
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries/search' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L88:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/providers/microsoft.insights/queryPacks' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L37:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries/{queryId}' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L148:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L112:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPacks_API.json#L73:5
1005 - RemovedPath The new version is missing a path that was found in the old version. Was path '/subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/providers/microsoft.insights/queryPacks/{queryPackName}/queries' removed or restructured?
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L37:5
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'categories' renamed or removed?
New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L452:7
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L332:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'code' renamed or removed?
New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L333:7
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L284:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'message' renamed or removed?
New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L333:7
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L284:7
1033 - RemovedProperty The new version is missing a property found in the old version. Was 'queryId' renamed or removed?
New: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L452:7
Old: Microsoft.Insights/preview/2019-09-01-preview/QueryPackQueries_API.json#L332:7
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-java - Release

️✔️ succeeded [Logs] [Expand Details]

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-js - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b25259d with merge commit 7006fdd. SDK Automation 13.0.17.20200807.2
  • ️✔️@azure/arm-appinsights [View full logs]  [Release SDK Changes]
    Only show 100 items here, please refer to log for details.
    [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
    [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
    [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
    [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
    [npmPack] loaded rollup.config.js with warnings
    [npmPack] (!) Unused external imports
    [npmPack] default imported from external module 'rollup' but never used
    [npmPack] 
    [npmPack] ./esm/applicationInsightsManagementClient.js → ./dist/arm-appinsights.js...
    [npmPack] created ./dist/arm-appinsights.js in 602ms
    [npmPack] npm notice 
    [npmPack] npm notice package: @azure/arm-appinsights@2.1.0
    [npmPack] npm notice === Tarball Contents === 
    [npmPack] npm notice 6.0kB   esm/operations/analyticsItems.js                                   
    [npmPack] npm notice 505B    esm/models/analyticsItemsMappers.js                                
    [npmPack] npm notice 6.1kB   esm/operations/annotations.js                                      
    [npmPack] npm notice 470B    esm/models/annotationsMappers.js                                   
    [npmPack] npm notice 5.3kB   esm/operations/aPIKeys.js                                          
    [npmPack] npm notice 499B    esm/models/aPIKeysMappers.js                                       
    [npmPack] npm notice 3.0kB   esm/applicationInsightsManagementClient.js                         
    [npmPack] npm notice 2.6kB   esm/applicationInsightsManagementClientContext.js                  
    [npmPack] npm notice 213.5kB dist/arm-appinsights.js                                            
    [npmPack] npm notice 76.3kB  dist/arm-appinsights.min.js                                        
    [npmPack] npm notice 2.1kB   esm/operations/componentAvailableFeatures.js                       
    [npmPack] npm notice 552B    esm/models/componentAvailableFeaturesMappers.js                    
    [npmPack] npm notice 3.5kB   esm/operations/componentCurrentBillingFeatures.js                  
    [npmPack] npm notice 514B    esm/models/componentCurrentBillingFeaturesMappers.js               
    [npmPack] npm notice 2.1kB   esm/operations/componentFeatureCapabilities.js                     
    [npmPack] npm notice 472B    esm/models/componentFeatureCapabilitiesMappers.js                  
    [npmPack] npm notice 6.1kB   esm/operations/componentLinkedStorageAccountsOperations.js         
    [npmPack] npm notice 905B    esm/models/componentLinkedStorageAccountsOperationsMappers.js      
    [npmPack] npm notice 2.0kB   esm/operations/componentQuotaStatus.js                             
    [npmPack] npm notice 456B    esm/models/componentQuotaStatusMappers.js                          
    [npmPack] npm notice 10.9kB  esm/operations/components.js                                       
    [npmPack] npm notice 990B    esm/models/componentsMappers.js                                    
    [npmPack] npm notice 7.6kB   esm/operations/exportConfigurations.js                             
    [npmPack] npm notice 507B    esm/models/exportConfigurationsMappers.js                          
    [npmPack] npm notice 7.2kB   esm/operations/favorites.js                                        
    [npmPack] npm notice 442B    esm/models/favoritesMappers.js                                     
    [npmPack] npm notice 345B    esm/models/index.js                                                
    [npmPack] npm notice 1.0kB   esm/operations/index.js                                            
    [npmPack] npm notice 1.7kB   esm/operations/liveToken.js                                        
    [npmPack] npm notice 426B    esm/models/liveTokenMappers.js                                     
    [npmPack] npm notice 68.1kB  esm/models/mappers.js                                              
    [npmPack] npm notice 3.6kB   esm/operations/operations.js                                       
    [npmPack] npm notice 522B    esm/models/operationsMappers.js                                    
    [npmPack] npm notice 8.4kB   esm/models/parameters.js                                           
    [npmPack] npm notice 5.2kB   esm/operations/proactiveDetectionConfigurations.js                 
    [npmPack] npm notice 857B    esm/models/proactiveDetectionConfigurationsMappers.js              
    [npmPack] npm notice 1.0kB   rollup.config.js                                                   
    [npmPack] npm notice 2.0kB   esm/operations/webTestLocations.js                                 
    [npmPack] npm notice 503B    esm/models/webTestLocationsMappers.js                              
    [npmPack] npm notice 9.9kB   esm/operations/webTests.js                                         
    [npmPack] npm notice 866B    esm/models/webTestsMappers.js                                      
    [npmPack] npm notice 6.3kB   esm/operations/workbooks.js                                        
    [npmPack] npm notice 878B    esm/models/workbooksMappers.js                                     
    [npmPack] npm notice 8.0kB   esm/operations/workItemConfigurations.js                           
    [npmPack] npm notice 543B    esm/models/workItemConfigurationsMappers.js                        
    [npmPack] npm notice 1.7kB   package.json                                                       
    [npmPack] npm notice 457B    tsconfig.json                                                      
    [npmPack] npm notice 2.6kB   esm/operations/analyticsItems.d.ts.map                             
    [npmPack] npm notice 3.4kB   esm/operations/analyticsItems.js.map                               
    [npmPack] npm notice 213B    esm/models/analyticsItemsMappers.d.ts.map                          
    [npmPack] npm notice 226B    esm/models/analyticsItemsMappers.js.map                            
    [npmPack] npm notice 2.5kB   esm/operations/annotations.d.ts.map                                
    [npmPack] npm notice 3.4kB   esm/operations/annotations.js.map                                  
    [npmPack] npm notice 224B    esm/models/annotationsMappers.d.ts.map                             
    [npmPack] npm notice 237B    esm/models/annotationsMappers.js.map                               
    [npmPack] npm notice 2.3kB   esm/operations/aPIKeys.d.ts.map                                    
    [npmPack] npm notice 3.0kB   esm/operations/aPIKeys.js.map                                      
    [npmPack] npm notice 209B    esm/models/aPIKeysMappers.d.ts.map                                 
    [npmPack] npm notice 222B    esm/models/aPIKeysMappers.js.map                                   
    [npmPack] npm notice 1.3kB   esm/applicationInsightsManagementClient.d.ts.map                   
    [npmPack] npm notice 1.9kB   esm/applicationInsightsManagementClient.js.map                     
    [npmPack] npm notice 505B    esm/applicationInsightsManagementClientContext.d.ts.map            
    [npmPack] npm notice 1.4kB   esm/applicationInsightsManagementClientContext.js.map              
    [npmPack] npm notice 494.3kB dist/arm-appinsights.js.map                                        
    [npmPack] npm notice 64.3kB  dist/arm-appinsights.min.js.map                                    
    [npmPack] npm notice 829B    esm/operations/componentAvailableFeatures.d.ts.map                 
    [npmPack] npm notice 1.1kB   esm/operations/componentAvailableFeatures.js.map                   
    [npmPack] npm notice 250B    esm/models/componentAvailableFeaturesMappers.d.ts.map              
    [npmPack] npm notice 263B    esm/models/componentAvailableFeaturesMappers.js.map                
    [npmPack] npm notice 1.4kB   esm/operations/componentCurrentBillingFeatures.d.ts.map            
    [npmPack] npm notice 1.8kB   esm/operations/componentCurrentBillingFeatures.js.map              
    [npmPack] npm notice 247B    esm/models/componentCurrentBillingFeaturesMappers.d.ts.map         
    [npmPack] npm notice 260B    esm/models/componentCurrentBillingFeaturesMappers.js.map           
    [npmPack] npm notice 833B    esm/operations/componentFeatureCapabilities.d.ts.map               
    [npmPack] npm notice 1.1kB   esm/operations/componentFeatureCapabilities.js.map                 
    [npmPack] npm notice 228B    esm/models/componentFeatureCapabilitiesMappers.d.ts.map            
    [npmPack] npm notice 241B    esm/models/componentFeatureCapabilitiesMappers.js.map              
    [npmPack] npm notice 2.4kB   esm/operations/componentLinkedStorageAccountsOperations.d.ts.map   
    [npmPack] npm notice 3.2kB   esm/operations/componentLinkedStorageAccountsOperations.js.map     
    [npmPack] npm notice 455B    esm/models/componentLinkedStorageAccountsOperationsMappers.d.ts.map
    [npmPack] npm notice 468B    esm/models/componentLinkedStorageAccountsOperationsMappers.js.map  
    [npmPack] npm notice 817B    esm/operations/componentQuotaStatus.d.ts.map                       
    [npmPack] npm notice 1.1kB   esm/operations/componentQuotaStatus.js.map                         
    [npmPack] npm notice 212B    esm/models/componentQuotaStatusMappers.d.ts.map                    
    [npmPack] npm notice 225B    esm/models/componentQuotaStatusMappers.js.map                      
    [npmPack] npm notice 4.8kB   esm/operations/components.d.ts.map                                 
    [npmPack] npm notice 6.6kB   esm/operations/components.js.map                                   

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 13, 2020

azure-sdk-for-net - Release

️✔️ succeeded [Logs] [Expand Details]
  • ️✔️ Generate from b25259d with merge commit 7006fdd. SDK Automation 13.0.17.20200807.2
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
    [AutoRest] realpath(): Permission denied
  • ️✔️Microsoft.Azure.ApplicationInsights [View full logs]  [Release SDK Changes]
      No Artifact Generated.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from b25259d with merge commit 7006fdd. SDK Automation 13.0.17.20200807.2
    • ⚠️azure-mgmt-applicationinsights [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-applicationinsights
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-applicationinsights
      [after_scripts|python] INFO:__main__:Default API version will be: v2020_03_01_preview
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] warning: no files found matching '*.py' under directory 'tests'
      [build_package] warning: no files found matching '*.yaml' under directory 'tests'
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 14.396% size of original (original: 75466 chars, delta: 10864 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter properties
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter system_data
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter tags
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter related
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery has a new parameter log_analytics_query_pack_query_id
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter ingestion_mode
      [ChangeLog]   - Model ApplicationInsightsComponent has a new parameter la_migration_date
      [ChangeLog]   - Model OperationDisplay has a new parameter description
      [ChangeLog]   - Model Operation has a new parameter origin
      [ChangeLog]   - Model Operation has a new parameter is_data_action
      [ChangeLog]   - Model AzureResourceProperties has a new parameter system_data
      [ChangeLog]   - Added operation QueriesOperations.update
      [ChangeLog]   - Added operation QueriesOperations.search
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Operation QueriesOperations.delete has a new signature
      [ChangeLog]   - Operation QueriesOperations.get has a new signature
      [ChangeLog]   - Operation QueriesOperations.put has a new signature
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter linked_resource_id
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter categories
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter labels
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter resource_types
      [ChangeLog]   - Model LogAnalyticsQueryPackQuery no longer has parameter query_id
      [ChangeLog]   - Model LogAnalyticsQueryPackQuerySearchProperties has a new signature

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Aug 13, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from b25259d with merge commit 7006fdd. Schema Automation 13.0.17.20200807.2
    • ⚠️applicationinsights [View full logs]  [Release Schema Changes]
        [after_scripts|node] PostProcessor finished successfully.
        [after_scripts|node]   5609 passing (40s)
        [after_scripts|node]   16 failing
        AzureResourceSchema has no registered package commands.

      @azuresdkci
      Copy link
      Contributor

      Can one of the admins verify this patch?

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2020
      @tofriedl
      Copy link
      Contributor Author

      i want to address 2 of the failed steps:

      #1 regarding Prettier check - i ran prettier for all files and prettier tool did not changed any file.
      #2 regarding BreakingChange - QueryPacks is a new resource under "microsoft.insights" RP and it is not yet exposed in any production region. no customer created any QueryPack yet, so this change cannot break any customer.

      Thanks, Tom.

      @mmyyrroonn mmyyrroonn removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 17, 2020
      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 17, 2020
      @mmyyrroonn
      Copy link
      Contributor

      Since there was not new api, remove ARM review requests.

      @mmyyrroonn mmyyrroonn removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 17, 2020
      @mmyyrroonn
      Copy link
      Contributor

      @tofriedl Could you try PrettierCheck again? It should work.

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @tofriedl
      Copy link
      Contributor Author

      tofriedl commented Aug 17, 2020

      @myronfanqiu - done. prettier was ran.

      @tofriedl tofriedl closed this Aug 17, 2020
      @tofriedl tofriedl reopened this Aug 17, 2020
      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @openapi-assignment-bot openapi-assignment-bot bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 17, 2020
      @mmyyrroonn
      Copy link
      Contributor

      @tofriedl Hi. Meanwhile, there is a lint error. Could you please add corresponding api into the file?

      @tofriedl
      Copy link
      Contributor Author

      @myronfanqiu - Lint error is "R3023 - OperationsAPIImplementation" but Microsoft.Insights RP do have Operations API implemented.
      the implementation can be found here:
      https://github.com/Azure/azure-rest-api-specs/blob/master/specification/applicationinsights/resource-manager/Microsoft.Insights/stable/2015-05-01/aiOperations_API.json

      @mmyyrroonn
      Copy link
      Contributor

      @tofriedl I thought this rule should be applied to each api version. @jianyexi Could you confirm?

      @jianyexi
      Copy link
      Contributor

      @tofriedl I thought this rule should be applied to each api version. @jianyexi Could you confirm?

      Correct, this rule will check if the changed API version has operations API

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @azure-pipelines
      Copy link

      Azure Pipelines successfully started running 1 pipeline(s).

      @tofriedl
      Copy link
      Contributor Author

      @myronfanqiu - i added Operations API. LintDiff check seems to success now.

      @mmyyrroonn mmyyrroonn added the Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 18, 2020
      @mmyyrroonn
      Copy link
      Contributor

      Since these apis have no real customers right now. It's not a real breaking change.

      @mmyyrroonn mmyyrroonn merged commit 7006fdd into Azure:master Aug 18, 2020
      Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
      Labels
      Approved-BreakingChange DO NOT USE! OBSOLETE label. See https://github.com/Azure/azure-sdk-tools/issues/6374 CI-BreakingChange-Python WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
      Projects
      None yet
      Development

      Successfully merging this pull request may close these issues.

      4 participants