Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev redis microsoft.cache 2020 06 01 #11011

Merged
merged 11 commits into from
Oct 14, 2020

Conversation

sspeaks610
Copy link
Contributor

@sspeaks610 sspeaks610 commented Oct 1, 2020

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

If any further question about AME onboarding or validation tools, please view the FAQ.

ARM API Review Checklist

  • Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

    • Adding new API(s)
    • Adding a new API version
    • Adding a new service
  • If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist

If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

  • Removing API(s) in stable version
  • Removing properties in stable version
  • Removing API version(s) in stable version
  • Updating API in stable version with Breaking Change Validation errors
  • Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 1, 2020

[Staging] Swagger Validation Report

️✔️BreakingChange [Detail]
 There are no breaking changes. 
️✔️LintDiff [Detail]
 Validation passes for LintDiff. 
️✔️Avocado [Detail]
 Validation passes for Avocado. 
️✔️ModelValidation [Detail]
 Validation passes for ModelValidation. 
️✔️SemanticValidation [Detail]
 Validation passes for SemanticValidation. 
Posted by Swagger Pipeline | How to fix these errors?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sspeaks610
Copy link
Contributor Author

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

Azure CLI Extension Generation - Release

No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2bdf735 with merge commit 8b447ea. SDK Automation 13.0.17.20200918.2
  • ️✔️preview/redis/mgmt/2019-07-01-preview [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:26:23 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0403:F31A:991ECBD:B1EF4D2:5F87891E","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ⚠️redis/mgmt/2015-08-01 [View full logs
    No file is changed.
  • ⚠️redis/mgmt/2016-04-01 [View full logs
    No file is changed.
  • ⚠️redis/mgmt/2017-02-01 [View full logs
    No file is changed.
  • ⚠️redis/mgmt/2017-10-01 [View full logs
    No file is changed.
  • ️✔️redis/mgmt/2018-03-01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:27:20 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0400:69B4:329F3EA:57D95D3:5F878958","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Oct 1, 2020

azure-sdk-for-java - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 2bdf735 with merge commit 8b447ea. SDK Automation 13.0.17.20200918.2
  • ️✔️sdk/redis/mgmt-v2017_10_01 [View full logs]  [Release SDK Changes]
    Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:19:01 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C2:440F:29903B:5D8F36:5F878765","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
  • ⚠️sdk/redis/mgmt-v2018_03_01 [View full logs]  [Release SDK Changes]
      [mvn] [ERROR] COMPILATION ERROR : 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[88,50] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[98,40] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[108,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[118,58] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[128,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project azure-mgmt-cache: Compilation failure: Compilation failure: 
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[88,50] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[98,40] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[108,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[118,58] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] /z/work/azure-sdk-for-java/sdk/redis/mgmt-v2018_03_01/src/main/java/com/microsoft/azure/management/redis/v2018_03_01/implementation/RedisManager.java:[128,56] incompatible types: com.microsoft.azure.management.redis.v2018_03_01.implementation.RedisManager cannot be converted to com.microsoft.azure.management.redis.v2018_03_01.implementation.CacheManager
      [mvn] [ERROR] -> [Help 1]
      [mvn] [ERROR] 
      [mvn] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
      [mvn] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
      [mvn] [ERROR] 
      [mvn] [ERROR] For more information about the errors and possible solutions, please read the following articles:
      [mvn] [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:19:13 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"07C1:0EDC:11FAF76A:14F26ED1:5F878771","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-sdk-for-js - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 2bdf735 with merge commit 8b447ea. SDK Automation 13.0.17.20200918.2
    • ️✔️@azure/arm-rediscache [View full logs]  [Release SDK Changes]
      Only show 100 items here, please refer to log for details.
      [npmPack] npm WARN deprecated rollup-plugin-node-resolve@5.2.0: This package has been deprecated and is no longer maintained. Please use @rollup/plugin-node-resolve.
      [npmPack] npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated
      [npmPack] npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated
      [npmPack] npm notice created a lockfile as package-lock.json. You should commit this file.
      [npmPack] loaded rollup.config.js with warnings
      [npmPack] (!) Unused external imports
      [npmPack] default imported from external module 'rollup' but never used
      [npmPack] 
      [npmPack] ./esm/redisManagementClient.js → ./dist/arm-rediscache.js...
      [npmPack] created ./dist/arm-rediscache.js in 373ms
      [npmPack] npm notice 
      [npmPack] npm notice package: @azure/arm-rediscache@4.0.0
      [npmPack] npm notice === Tarball Contents === 
      [npmPack] npm notice 124.8kB dist/arm-rediscache.js                               
      [npmPack] npm notice 43.2kB  dist/arm-rediscache.min.js                           
      [npmPack] npm notice 6.1kB   esm/operations/firewallRules.js                      
      [npmPack] npm notice 837B    esm/models/firewallRulesMappers.js                   
      [npmPack] npm notice 345B    esm/models/index.js                                  
      [npmPack] npm notice 591B    esm/operations/index.js                              
      [npmPack] npm notice 7.4kB   esm/operations/linkedServer.js                       
      [npmPack] npm notice 844B    esm/models/linkedServerMappers.js                    
      [npmPack] npm notice 43.5kB  esm/models/mappers.js                                
      [npmPack] npm notice 2.3kB   esm/operations/operations.js                         
      [npmPack] npm notice 499B    esm/models/operationsMappers.js                      
      [npmPack] npm notice 2.9kB   esm/models/parameters.js                             
      [npmPack] npm notice 6.0kB   esm/operations/patchSchedules.js                     
      [npmPack] npm notice 804B    esm/models/patchSchedulesMappers.js                  
      [npmPack] npm notice 7.2kB   esm/operations/privateEndpointConnections.js         
      [npmPack] npm notice 823B    esm/models/privateEndpointConnectionsMappers.js      
      [npmPack] npm notice 2.0kB   esm/operations/privateLinkResources.js               
      [npmPack] npm notice 811B    esm/models/privateLinkResourcesMappers.js            
      [npmPack] npm notice 19.2kB  esm/operations/redis.js                              
      [npmPack] npm notice 2.1kB   esm/redisManagementClient.js                         
      [npmPack] npm notice 2.7kB   esm/redisManagementClientContext.js                  
      [npmPack] npm notice 1.0kB   esm/models/redisMappers.js                           
      [npmPack] npm notice 987B    rollup.config.js                                     
      [npmPack] npm notice 1.7kB   package.json                                         
      [npmPack] npm notice 457B    tsconfig.json                                        
      [npmPack] npm notice 254.5kB dist/arm-rediscache.js.map                           
      [npmPack] npm notice 36.6kB  dist/arm-rediscache.min.js.map                       
      [npmPack] npm notice 2.8kB   esm/operations/firewallRules.d.ts.map                
      [npmPack] npm notice 3.6kB   esm/operations/firewallRules.js.map                  
      [npmPack] npm notice 432B    esm/models/firewallRulesMappers.d.ts.map             
      [npmPack] npm notice 445B    esm/models/firewallRulesMappers.js.map               
      [npmPack] npm notice 15.6kB  esm/models/index.d.ts.map                            
      [npmPack] npm notice 273B    esm/operations/index.d.ts.map                        
      [npmPack] npm notice 126B    esm/models/index.js.map                              
      [npmPack] npm notice 288B    esm/operations/index.js.map                          
      [npmPack] npm notice 2.6kB   esm/operations/linkedServer.d.ts.map                 
      [npmPack] npm notice 3.9kB   esm/operations/linkedServer.js.map                   
      [npmPack] npm notice 430B    esm/models/linkedServerMappers.d.ts.map              
      [npmPack] npm notice 443B    esm/models/linkedServerMappers.js.map                
      [npmPack] npm notice 2.4kB   esm/models/mappers.d.ts.map                          
      [npmPack] npm notice 23.9kB  esm/models/mappers.js.map                            
      [npmPack] npm notice 1.0kB   esm/operations/operations.d.ts.map                   
      [npmPack] npm notice 1.4kB   esm/operations/operations.js.map                     
      [npmPack] npm notice 241B    esm/models/operationsMappers.d.ts.map                
      [npmPack] npm notice 254B    esm/models/operationsMappers.js.map                  
      [npmPack] npm notice 733B    esm/models/parameters.d.ts.map                       
      [npmPack] npm notice 2.2kB   esm/models/parameters.js.map                         
      [npmPack] npm notice 2.6kB   esm/operations/patchSchedules.d.ts.map               
      [npmPack] npm notice 3.6kB   esm/operations/patchSchedules.js.map                 
      [npmPack] npm notice 421B    esm/models/patchSchedulesMappers.d.ts.map            
      [npmPack] npm notice 434B    esm/models/patchSchedulesMappers.js.map              
      [npmPack] npm notice 2.3kB   esm/operations/privateEndpointConnections.d.ts.map   
      [npmPack] npm notice 3.4kB   esm/operations/privateEndpointConnections.js.map     
      [npmPack] npm notice 445B    esm/models/privateEndpointConnectionsMappers.d.ts.map
      [npmPack] npm notice 458B    esm/models/privateEndpointConnectionsMappers.js.map  
      [npmPack] npm notice 823B    esm/operations/privateLinkResources.d.ts.map         
      [npmPack] npm notice 1.1kB   esm/operations/privateLinkResources.js.map           
      [npmPack] npm notice 433B    esm/models/privateLinkResourcesMappers.d.ts.map      
      [npmPack] npm notice 446B    esm/models/privateLinkResourcesMappers.js.map        
      [npmPack] npm notice 6.5kB   esm/operations/redis.d.ts.map                        
      [npmPack] npm notice 10.8kB  esm/operations/redis.js.map                          
      [npmPack] npm notice 841B    esm/redisManagementClient.d.ts.map                   
      [npmPack] npm notice 1.1kB   esm/redisManagementClient.js.map                     
      [npmPack] npm notice 509B    esm/redisManagementClientContext.d.ts.map            
      [npmPack] npm notice 1.4kB   esm/redisManagementClientContext.js.map              
      [npmPack] npm notice 529B    esm/models/redisMappers.d.ts.map                     
      [npmPack] npm notice 542B    esm/models/redisMappers.js.map                       
      [npmPack] npm notice 3.1kB   README.md                                            
      [npmPack] npm notice 7.0kB   esm/operations/firewallRules.d.ts                    
      [npmPack] npm notice 12.9kB  src/operations/firewallRules.ts                      
      [npmPack] npm notice 527B    esm/models/firewallRulesMappers.d.ts                 
      [npmPack] npm notice 834B    src/models/firewallRulesMappers.ts                   
      [npmPack] npm notice 44.8kB  esm/models/index.d.ts                                
      [npmPack] npm notice 275B    esm/operations/index.d.ts                            
      [npmPack] npm notice 42.8kB  src/models/index.ts                                  
      [npmPack] npm notice 559B    src/operations/index.ts                              
      [npmPack] npm notice 6.9kB   esm/operations/linkedServer.d.ts                     
      [npmPack] npm notice 12.7kB  src/operations/linkedServer.ts                       
      [npmPack] npm notice 534B    esm/models/linkedServerMappers.d.ts                  
      [npmPack] npm notice 842B    src/models/linkedServerMappers.ts                    
      [npmPack] npm notice 3.3kB   esm/models/mappers.d.ts                              
      [npmPack] npm notice 34.6kB  src/models/mappers.ts                                
      [npmPack] npm notice 2.1kB   esm/operations/operations.d.ts                       
      [npmPack] npm notice 4.2kB   src/operations/operations.ts                         
      [npmPack] npm notice 189B    esm/models/operationsMappers.d.ts                    
      [npmPack] npm notice 467B    src/models/operationsMappers.ts                      
      [npmPack] npm notice 878B    esm/models/parameters.d.ts                           

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-sdk-for-net - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 2bdf735 with merge commit 8b447ea. SDK Automation 13.0.17.20200918.2
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
      [AutoRest] realpath(): Permission denied
    • ️✔️Microsoft.Azure.Management.Redis [View full logs]  [Release SDK Changes]
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:19:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"06C1:62E4:545C9C:89F092:5F878776","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-sdk-for-python - Release

    - Breaking Change detected in SDK

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 2bdf735 with merge commit 8b447ea. SDK Automation 13.0.17.20200918.2
    • ⚠️azure-mgmt-redis [View full logs]  [Release SDK Changes] Breaking Change Detected
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-redis
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-redis
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      Unable to get details about the head commit. This is probably because the head commit is in a fork that we don't have permission to read from. HttpError: Not Found {"name":"HttpError","status":404,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, Deprecation, Sunset","connection":"close","content-encoding":"gzip","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 14 Oct 2020 23:17:30 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"404 Not Found","strict-transport-security":"max-age=31536000; includeSubdomains; preload","transfer-encoding":"chunked","vary":"Accept-Encoding, Accept, X-Requested-With","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.v3; param=machine-man-preview; format=json","x-github-request-id":"0548:719F:9FE10D3:B93F922:5F87870A","x-xss-protection":"1; mode=block"},"request":{"method":"POST","url":"https://api.github.com/app/installations//access_tokens","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.43.1 Node.js/13.14.0 (Linux 5.4; x64)","authorization":"bearer [REDACTED]","content-type":"application/json; charset=utf-8"},"body":"{}","request":{"validate":{"commit_sha":{"alias":"ref","deprecated":true,"type":"string"},"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"},"sha":{"alias":"ref","deprecated":true,"type":"string"}}}},"documentation_url":"https://docs.github.com/rest"}
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 42.096% size of original (original: 28530 chars, delta: 12010 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model RedisUpdateParameters has a new parameter public_network_access
      [ChangeLog]   - Model RedisResource has a new parameter public_network_access
      [ChangeLog]   - Model RedisResource has a new parameter private_endpoint_connections
      [ChangeLog]   - Model RedisCreateParameters has a new parameter public_network_access
      [ChangeLog]   - Added operation FirewallRulesOperations.list
      [ChangeLog]   - Added operation RedisOperations.list_by_subscription
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
      [ChangeLog]   - Added operation group PrivateLinkResourcesOperations
      [ChangeLog] 
      [ChangeLog] **Breaking changes**
      [ChangeLog] 
      [ChangeLog]   - Removed operation FirewallRulesOperations.list_by_redis_resource
      [ChangeLog]   - Removed operation RedisOperations.list

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-sdk-for-python

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from b9bcd64 with merge commit c159b1e9f95ab7c615b9695bf8c9a05810fcd33a. SDK Automation 13.0.17.20200918.2
    • ️✔️azure-mgmt-redis [View full logs]  [Preview SDK Changes]
      [build_conf] INFO:packaging_tools:Building template azure-mgmt-redis
      [build_conf] INFO:packaging_tools.conf:Skipping default conf since the file exists
      [build_conf] INFO:packaging_tools:Skipping CHANGELOG.md template, since a previous one was found
      [build_conf] INFO:packaging_tools:Template done azure-mgmt-redis
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [breaking_change_setup] Ignoring mock: markers 'python_version <= "2.7"' don't match your environment
      [ChangeLog] Size of delta 41.151% size of original (original: 28534 chars, delta: 11742 chars)
      [ChangeLog] **Features**
      [ChangeLog] 
      [ChangeLog]   - Model RedisCreateParameters has a new parameter public_network_access
      [ChangeLog]   - Model RedisUpdateParameters has a new parameter public_network_access
      [ChangeLog]   - Model RedisResource has a new parameter public_network_access
      [ChangeLog]   - Model RedisResource has a new parameter private_endpoint_connections
      [ChangeLog]   - Added operation group PrivateEndpointConnectionsOperations
      [ChangeLog]   - Added operation group PrivateLinkResourcesOperations

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    Trenton Generation - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-resource-manager-schemas - Release

    ⚠️ warning [Logs] [Expand Details]
    • ⚠️ Generate from 2bdf735 with merge commit 8b447ea. Schema Automation 13.0.17.20200918.2
      Failed to find any diff after autorest so no changed packages was found.

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Oct 1, 2020

    azure-sdk-for-python-track2 - Release

    No readme.md specification configuration files were found that are associated with the files modified in this pull request, or swagger_to_sdk section in readme.md is not configured

    @markcowl
    Copy link
    Member

    markcowl commented Oct 2, 2020

    @sspeaks610 Please read through the PR template in the comments section above and check-off the necessary checks. We cannot review the PR until this is complete

    @markcowl markcowl added the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 2, 2020
    @sspeaks610
    Copy link
    Contributor Author

    @markcowl Apologies! Should be good now. We already got an ARM review on a private PR here
    https://github.com/Azure/azure-rest-api-specs-pr/pull/1894

    Copy link
    Member

    @markcowl markcowl left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    A couple of minor operation naming comments, otherwise LGTM

    "tags": [
    "Redis"
    ],
    "operationId": "Redis_List",
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Normally this is called ListBySubscription, rather than List

    "Redis",
    "FirewallRules"
    ],
    "operationId": "FirewallRules_ListByRedisResource",
    Copy link
    Member

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Is there another way to list firewall rules? If not, this can just be List

    @markcowl
    Copy link
    Member

    markcowl commented Oct 6, 2020

    @sspeaks610 A couple of minor comments, please take a look. Otherwise, LGTM

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 1 pipeline(s).

    @markcowl
    Copy link
    Member

    /azp run

    @azure-pipelines
    Copy link

    Azure Pipelines successfully started running 3 pipeline(s).

    @markcowl markcowl removed the Reviewed-ChangesRequested <valid label in PR review process>add this label when assignee request changes after review label Oct 14, 2020
    @markcowl
    Copy link
    Member

    @sspeaks610 Waiting for ci, otherwise LGTM

    @markcowl markcowl merged commit 8b447ea into Azure:master Oct 14, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants